Bug#555684: Generic inferencing causing FTBFS for guava-libraries
On Wed, Jun 1, 2011 at 8:53 AM, James Page <james.page@canonical.com> wrote:
> Take a look and see what you think.
Hi James,
Thank you very much for taking a look at this, I even didn't have time to ask
for help in debian-java.
A priori I think your patch is correct because after disassembling the
problematic classes com.google.collections.collect.{Maps,SortedMaps}
from upstream and comparing them with the code generated with
openjdk-6-jdk in Debian, there are no differences. Although this is
after type erasure of generics.
I also built this code with sun-java6-jdk without issues.
The only thing what worries me is the comment in the code:
// Ideally, the extra type parameter "C" shouldn't be necessary
My hunch says let's go with the patch and monitor closely the issues
reported with upstream and openjdk6 compiler.
Cheers,
--
Miguel Landaeta, miguel at miguel.cc
secure email with PGP 0x7D8967E9 available at http://keyserver.pgp.com/
"Faith means not wanting to know what is true." -- Nietzsche
Reply to: