[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#603699: ITP: celt051 -- The CELT codec v0.5.1



On Tue, 2010-11-16 at 22:11 +0100, Adrian Knoth wrote:
[...]
> Anyway, there's
> 
>    http://www.spice-space.org/docs/spice_protocol.pdf
> 
> and it says it's a draft, so I guess it can still be reworked. But
> still, if you see section 7 and 8, you'll notice two constants:
> 
>    RED_PLAYBACK_DATA_MODE_RAW        = 1
>    RED_PLAYBACK_DATA_MODE_CELT_0_5_1 = 2
> 
> And the mode constants are used in an uint32 (section 7.5).
> 
> So why on earth don't you simply define a
> RED_PLAYBACK_DATA_MODE_CELT_0_9_whatever, make this number three and
> that's it?
> 
> Ok, you'll lose backward compatibility to non-celt-0.9 installations
> already deployed and not being able to update... but who's using them?
> And who will be using them by 2011?

RHEL 6 is presumably using this version of SPICE, so I would expect
there will be many such installations and they will stay around for many
years.

> If there's such a legacy user base, then I suggest to embed your private
> copy of celt-0.5.1 into the spice client source. For everyone else, it's
> the wrong signal to expect any CELT version (below 1.0) to be widely
> installed anywhere.
[...]

This sounds like a sensible solution so long as there is only one SPICE
implementation in Debian.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: