Back to business after holidays.
Thanks a lot Jordi, the MAME package is evolving faster with updates
from Emmunuel and Félix. The help of a Debian developer to finalize
and (I hope) upload it is greatly appreciated!
About Alioth, as said by Emmunuel, we were not allowed to create a
project because none of us are Debian developer/maintainer so we
hosted ourselves the "mamedeb" project. In my opinion, there is no
problem to switch from our VCS (Git) to Alioth if we can keep the
history of our previous commits.
About debian/changelog, I would really like to keep a log of all the
initial work and bugfixes but I was not sure if I can put them as-is.
About the "longest path ever" :) I have put the files into subfolders in
order to separate "media" and link files from the "core" debian files.
There are no other reason, so I'll put them on the debian folder.
Sed separator replacement is on the way, ugly slashes escaping
is replaced by "_" in most of the commands:
sed -i 's_[ +]comments_ /var/games/mame/comments;comments_' $INIFILE
MAN pages are completed now: ldresample, mame-regrep, mame-split,
mame-src2html, mame-srcclean, unidasm and mame.
About the "chmod o+rw" on the postinst: it is here to allow end-user
to move/delete/save ROMs or ini files in this folder. In fact it is not
necessary because end user will have it's own ini and ROM path so
I'll remove it.
Thanks a lot.
--
Ludo.
On Sat, Nov 6, 2010 at 7:28 AM, Jordi Mallach
<jordi@debian.org> wrote:
Hi!
On Fri, Nov 05, 2010 at 06:06:06PM +0100, Emmanuel Kasper wrote:
> Ludo did most of the packaging work, I commited some fix for powerpc.
>
> Right now the two packages ( mame and mame-tools) are lintian clean
> exepct for debian-helper overrides warning and the packaging code is
> available from download from:
>
http://indefero.shaperstudio.com/p/mamedeb/
>
> This will build a mame v 0.139 binary ( althoug upstream has just
> released 0.140 )
>
> We have also a mailing list at
http://groups.google.com/group/mamedeb
the packages to mentors.debian.net. If you don't have Alioth accounts, you
should apply for one now.
In the bug report, others have suggested hosting mame in the games
packaging team repository. I think it's a good idea, but it's your call. I
don't think the Alioth admins are really happy about creating new groups
for just one app, and MAME really fits well in the games repo, while that
does not mean you'll lose control over your package.
As for the mailing list, you might want to just use the pkg-games-devel
list.
> A feedback on the packaging is more than welcome !
This is very good!
Ludo: I don't know where all the packaging history went. If you've been
maintaining mame for years, I don't see why you should be getting rid of
your entire debian/changelog. There's nothing bad in doing that, it just
doesn't show all the previous work behind the package.
You should probably update the package to the newest Standards-Version. I
also suggest you convert it to DpkgSource v3, as you're using quilt
anyway. If you need help with this, just say!
http://wiki.debian.org/Projects/DebSrc3.0
Nitpicks in the control file:
Extra newline between source package and mame binary package.
Description:
- "... is a hardware emulator..."
- This package provides the MAME binary..."
- Remove the authorship information. That will be available in the
copyright file.
- No space between a word and :
This package provides tools to be used with MAME:
In the copyright file, you refer to BSD, GPL and LGPL, but no links to
common-licenses.
dhdcd.c and others don't have an explicit copyright notice in the header,
but a pointer to MAME's website. You should probably tell upstream about
this.
Why do you put the .desktop and .xpm file in a deep dir inside the debian
dir? Why not move them to debian/, and reference those files in
mame.install (like you do, but using the longest path ever!)
A suggestion: on your sed constructs, use another separator and avoid
escaping the slashes:
sed -i 's%\( comments\).*%\1;/var/games/mame/comments%' $INIFILE
You should not run find -exec chmod on every upgrade. If there are a lot
of files in that dir, installation could take ages.
Many manual pages need a bit more work ("etc." all over the place!)
Finally, as you need to repack the .zip, why not do a .tar.bz2?