Hi again, On Wed, 2010-05-05 at 14:44 -0400, Adam C Powell IV wrote: > On Wed, 2010-05-05 at 09:40 +0200, Andre Espaze wrote: > > > Second, I've cut the number of lintian warnings by dozens by making > > > the .py files non-executable. The one problem that results is during > > > startup, which can be solved by the following patch: > > > > > > diff --git a/KERNEL_SRC_5.1.3/bin/runSalome.py b/KERNEL_SRC_5.1.3/bin/runSalome.py > > > index d67d6b0..550a6c2 100755 > > > --- a/KERNEL_SRC_5.1.3/bin/runSalome.py > > > +++ b/KERNEL_SRC_5.1.3/bin/runSalome.py > > > @@ -191,7 +191,7 @@ class ContainerPYServer(Server): > > > if sys.platform == "win32": > > > self.CMD=[os.environ["PYTHONBIN"], '\"'+os.environ["KERNEL_ROOT_DIR"] + '/bin/salome/SALOME_ContainerPy.py'+'\"','FactoryServerPy'] > > > else: > > > - self.CMD=['SALOME_ContainerPy.py','FactoryServerPy'] > > > + self.CMD=['python','/usr/lib/python2.5/site-packages/salome/SALOME_ContainerPy.py','FactoryServerPy'] > > > > > > # --- > > > > > > My python is even worse than my French, so that's the best I can do, but > > > I'm certain there's a better way. Can someone help my pathetic python, > > > hopefully in a way that will be acceptable to upstream? > > I think that SALOME_ContainerPy.py should be considered as an executable > > script because its first line starts with: > > > > #! /usr/bin/env python > > > > As a consequence, it should live inside /usr/bin like others commands > > so no patch is required. The only reproach to upstream may be to keep > > the '.py' extension which is confusing because SALOME_ContainerPy is > > supposed to be a command. I have moved SALOME_ContainerPy.py to /usr/bin > > and made it executable and Salome was still working. I think that it > > should be possible to add this behavior to the Debian package during > > the installation step. What is your opinion on this point? Would you > > like me to work on a patch? > > Sure, though I think it might make sense to remove the .py from the > ending then, like avs2med and a couple of others. In Debian, executable > scripts are not supposed to have extensions, not even .sh . > > Make sure your patch eventually puts it into the /usr/bin directory of > the python2.5-salome package, or else it will generate another lintian > error (python script without python dependency). I just took care of this, the result is in the alioth git repository. I'm going to build and test -8 with this and -doc package removal, and a couple of other little changes, then test and re-upload. -Adam -- GPG fingerprint: D54D 1AEE B11C CE9B A02B C5DD 526F 01E8 564E E4B6 Engineering consulting with open source tools http://www.opennovation.com/
Attachment:
signature.asc
Description: This is a digitally signed message part