Bug#426048: about your fuppes ITP.
Hello!
I've read the comments in the fuppes ITP and quickly looked at
fuppes collab-maint git repo.
It seems you neither have an "upstream" branch, nor anything else
to assist you with creating the orig tarball.
You might want to investigate git-import-orig and the pristine-tar
option.
You might want to work some more on the long descriptions of
some of the packages. It's common to include a brief description
of what the main package is and what use it has in the
plugin packages as well... Imagine someone stumpling
upon any of your binary packages for the first time and
don't know anything about them.
You could drop the things you don't need in your debian/rules
to clean it up (or even consider switching to dh7 for a really
clean rules file).
I read something in the ITP comments about warnings of unneccessary
ldconfig calls and similar. This is usually because of plugins
being incorrectly treated as regular shared libraries.
You might want to exclude /usr/lib/fuppes/* when running dh_makeshlibs:
dh_makeshlibs -X /usr/lib/fuppes/
Also, your postinst/rm scripts seems to manually run ldconfig
on configure every time rather then relying on debhelper adding
it (only) when needed.
While at, do you really want to have the debian/shlibs.* included
in your git repo? You generate them at build time.....
I hope my quick review helps you get the package in even better
shape for sponsorship review.
You're more then welcome to steal packaging ideas from
http://git.debian.org/?p=collab-maint/rygel.git
(See debian/README.source for comments about dealing with pristine-tar, et.al.)
With friendly greetings from the competition!
Andreas Henriksson
(Rygel packaging team member)
Reply to: