Bug#522984: magics++_2.6.4+dfsg-1_i386.changes REJECTED
Hi,
Thank you for your diligence. I had included the various licenses
refereed to in magics++
in debian/copyright, but missed these.
Joerg Jaspert wrote:
Hi Maintainer,
rejected, various problems:
- Lacking good copyright info in debian/copyright.
- gshhs/coast/gshh_h.b seems to be a binary file, what is the source?
gshss ("Global Self-consistant Hierarchical High-resolution Shorelines")
is described in debian/copyright. Its a GNU-licensed project : the .b
file is a data file,
but apparently can be generated. gshhs is also used by zgGrib, which I
am also packaging, so
I will probably do gshss as a separate debian package, and Depend: on it
rather than include
two copies of these binary files.
http://www.ngdc.noaa.gov/mgg/shorelines/data/gshhs/version1.10/readme.txt
- DejaVu fonts should have license/copyright info in the copyright file
even though source is modified to use external (good!), since they are
included in the source and we do distribute source too.
Ok, will do.
- src/terralib/jpeg/* seem to be Copyright Intel and has unclear
licensing. Especially the header in ihl.h is bad.
Terralib is also a library present in Debian, but only an old version
(3.0) in etch. The current version
3.3.1 is available, and uses libjpeg rather than these Intel files. It
seems a good idea to update this.
I may take over terralib to do so, and remove the terralib sources from
the dfsg.
- test/data/* seem to be binary files. Is there a way to generate / edit
those using tools available in Debian? If so, which, and where is the
source? Or are they to be handled like images (jpg/png/whatever)?
This should be handled like images, in my opinion. They probably came
from instrumental / model results,
rather than being generated by 'hidden sources'.
In your opinion, with these changes made, would magics++be accepted ?
Regards
Alastair
Reply to: