Bug#528247: ITP: python-django-djapian -- Full-text search for Django
On Fri, Dec 04, 2009 at 09:57:50PM +0300, Mikhail Lukyanchenko wrote:
> 2009/11/30 Olly Betts <olly@survex.com>
> > Also, the copyright statements must have year(s), or the ftpmasters will
> > reject the package:
> > http://lists.debian.org/debian-devel-announce/2006/03/msg00023.html
>
> I use years of first/last commit from Subversion repository. Can it be
> considered as a reliable source? Should I mention that source somehow?
I can't speak for what the ftpmasters would accept, but that seems a
reasonable source if the authors don't supply such information and there's
no reason to think the code's history pre-dates the use of the VCS.
But they've added an explicit licence with (C) years in response to your
ticket now:
http://djapian.googlecode.com/svn-history/r320/trunk/LICENSE
> > Also "new upstream version" is more conventional than "Imported Upstream
> > version 2.3" - see:
> > http://www.debian.org/doc/developers-reference/pkgs.html#changelog-entries
>
> It's message from git-import-orig. I thought it's ok to leave it as is. Fixed.
Google suggests people just use the message git-import-orig adds, and the
message is pretty clear, so feel free to leave as is in future.
If you're using a public VCS to maintain the packaging, it's useful to
specify its location in control:
http://www.debian.org/doc/developers-reference/best-pkging-practices.html#bpp-vcs
> > And the "Closes: #528247" really belongs in the section for the version
> > which actually gets uploaded, as that's the one which actually means the
> > ITP bug can be closed.
Actually, I'm not sure about my logic here. The bug is addressed in the
version which you addressed it in, whether or not that is actually
uploaded.
> May be changelog should contain only one entry: 'Initial release
> (Closes: #528247)'. Is it correct?
There are differing opinions on this issue, but "collapsing" entries for
versions which were never really publicly released is certainly a valid
approach, and tidier.
Putting the package on mentors.debian.net and sending the URL to the BTS is
a form of public release, but I wouldn't expect anyone to install a package
from such a source. It would be different to if you'd made this available
in a personal repository for the past months.
So I think that probably is correct in this case.
> - dget http://mentors.debian.net/debian/pool/main/p/python-django-djapian/python-django-djapian_2.3-1.dsc
OK, so just 3 issues remaining:
The "Copyright (c) The Regents of the University of California" and "THE
REGENTS" in debian/copyright isn't correct for djapian (as its code doesn't
originate at UCB, it just uses the licence). I think that definitely needs
fixing, and now upstream have provided an explicit LICENSE file that's easy
to do.
I'd suggest ensuring debian/copyright and debian/changelog end with a
newline (I'm not aware of this being a requirement, but it's saner for text
files to generally, and less likely to trip up tools which try to parse
them).
And if your VCS is public, adding Vcs- headers to control would be good.
Cheers,
Olly
Reply to: