Hi, I found your package via the OpenMoko wiki. I'd like to sponsor your osm2go package for upload to Debian. Unfortunately there are some issues with it, review below: You (optionally) build-depend on the OpenSSL version of curl, but the upstream code is GPLv3, which is incompatible with the OpenSSL license. The upstream code uses libgnomeui, which is deprecated: http://live.gnome.org/LibgnomeMustDie Please talk to upstream and get them to switch away from it. You depend on debhelper 7 but don't use dh or any of the other nice new debhelper 7 features. You also don't use compat level 7. Your Standards-Version is outdated, please read upgrading-checklist.txt from the latest version of debian-policy and then update the Standards-Version. Please note that the Standards-Version is meant to be only 3 numbers, not 4 as minor versions are compatible. Please merge the desktop file, manual page and SVG image upstream. You hard-code a depends on libgoocanvas3 instead of letting dh_shlibdeps add it to the depends. The debian/postinst file can be removed since it is basically empty and debhelper will fill it in anyway. Please ask upstream to implement 'make install' or if they already have, please use it in debian/rules. Too many commented-out lines in debian/rules, just remove them. dh_desktop is deprecated and does nothing, do not use it. gcc warnings (please forward upstream): gcc -Wall -O2 -DPACKAGE=\"osm2go\" -DPREFIX=\"/usr\" -DUSE_GOOCANVAS `pkg-config --cflags gtk+-2.0 libxml-2.0 goocanvas libcurl gthread-2.0 gnome-vfs-module-2.0 libgnome-2.0` -o gps.o -c gps.c gps.c: In function 'gps_thread': gps.c:214: warning: format '%d' expects type 'int', but argument 3 has type 'size_t' gcc -Wall -O2 -DPACKAGE=\"osm2go\" -DPREFIX=\"/usr\" -DUSE_GOOCANVAS `pkg-config --cflags gtk+-2.0 libxml-2.0 goocanvas libcurl gthread-2.0 gnome-vfs-module-2.0 libgnome-2.0` -o project.o -c project.c project.c: In function 'project_filesize': project.c:824: warning: format '%d' expects type 'int', but argument 2 has type 'gsize' gcc -Wall -O2 -DPACKAGE=\"osm2go\" -DPREFIX=\"/usr\" -DUSE_GOOCANVAS `pkg-config --cflags gtk+-2.0 libxml-2.0 goocanvas libcurl gthread-2.0 gnome-vfs-module-2.0 libgnome-2.0` -o net_io.o -c net_io.c net_io.c: In function 'worker_thread': net_io.c:219: warning: call to '_curl_easy_setopt_err_progress_cb' declared with attribute warning: curl_easy_setopt expects a curl_progress_callback argument for this option dpkg-shlibdeps warnings: dpkg-shlibdeps: warning: dependency on libbonobo-activation.so.4 could be avoided if "debian/osm2go/usr/bin/osm2go" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libfontconfig.so.1 could be avoided if "debian/osm2go/usr/bin/osm2go" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libatk-1.0.so.0 could be avoided if "debian/osm2go/usr/bin/osm2go" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on librt.so.1 could be avoided if "debian/osm2go/usr/bin/osm2go" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libpopt.so.0 could be avoided if "debian/osm2go/usr/bin/osm2go" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libpthread.so.0 could be avoided if "debian/osm2go/usr/bin/osm2go" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libgio-2.0.so.0 could be avoided if "debian/osm2go/usr/bin/osm2go" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libcairo.so.2 could be avoided if "debian/osm2go/usr/bin/osm2go" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libpango-1.0.so.0 could be avoided if "debian/osm2go/usr/bin/osm2go" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libbonobo-2.so.0 could be avoided if "debian/osm2go/usr/bin/osm2go" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libpangocairo-1.0.so.0 could be avoided if "debian/osm2go/usr/bin/osm2go" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libfreetype.so.6 could be avoided if "debian/osm2go/usr/bin/osm2go" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libORBit-2.so.0 could be avoided if "debian/osm2go/usr/bin/osm2go" were not uselessly linked against it (they use none of its symbols). dpkg-shlibdeps: warning: dependency on libpangoft2-1.0.so.0 could be avoided if "debian/osm2go/usr/bin/osm2go" were not uselessly linked against it (they use none of its symbols). Complaints from lintian --info --display-info --display-experimental --pedantic --show-overrides --checksums --color auto W: osm2go source: dh_desktop-is-deprecated line 96 I: osm2go: arch-dep-package-has-big-usr-share 1552kB 86% I: osm2go: copyright-with-old-dh-make-debian-copyright -- bye, pabs http://wiki.debian.org/PaulWise
Attachment:
signature.asc
Description: This is a digitally signed message part