[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#524790: Fwd: Re: Fwd: Built a package for fio



Hi Jens, Hendrik and Michael!

I am forwarding this to the bug report as it is my review of the differences 
of my package and the one built by you, Hendrik.

I already updated my package to fio-1.32. I will send a mail about this after 
this one.

After updating my package today, I found that Hendrik send me a subversion URL 
for fetching his package in a mail to me and Jens Axboe only - as the above 
review it didn't went to this bug report:

"Martin, feel free to fetch the package source from
http://svn.debian.org/wsvn/collab-maint/ext-maint/fio or
svn+ssh://svn.debian.org/svn/collab-maint/ext-maint
You are very welcome to get/check/fix things there"

The HTTP URL seems to be (note the slash at the end):

http://svn.debian.org/wsvn/collab-maint/ext-maint/fio/

But I still did not get it checked out:

ms@mango:~/lokal/Debian> LANG=C svn checkout 
http://svn.debian.org/wsvn/collab-maint/ext-maint/fio/
svn: XML data was not well-formed

Maybe the WebDAV/SVN HTTP URL is different?


I included the examples as documentation in my package already, but I like to 
compare Copyright files as well. Any hint on how to checkout the package from 
Hendrik?

Information of my current package will follow shortly.

Ciao,
Martin



----------  Weitergeleitete Nachricht  ----------

Betreff: Re: Fwd: Built a package for fio
Date: Mittwoch, 20. Mai 2009
Von: Martin Steigerwald <ms@teamix.de>
An: Hendrik Frenzel <hfrenzel@scunc.net>
Kopie: 

Am Dienstag, 19. Mai 2009 schrieb Hendrik Frenzel:
> Martin Steigerwald schrieb:
> > The manpage needs a little fix in order to pass lintian
>
> This is already fixed in my packages.
>
> They are nearly ready for upload.
> I just have to remove the .git/ from the source to get it clean for Debian.
>
> Martin, feel free to fetch the package source from
> http://svn.debian.org/wsvn/collab-maint/ext-maint/fio or
> svn+ssh://svn.debian.org/svn/collab-maint/ext-maint
> You are very welcome to get/check/fix things there :)

I had a look at the web url as I don't have SSH access to debian hosts.

I have a couple of comments / suggestions:

1) Could you add my manpage for fio_generate_plots? It helps making the 
package lintian clean and I think it adds some value for the end user as 
well. That might be something for you, Jens, as well, to integrate upstream.

2) Your doc file is missing out the HOWTO and REPORTING-BUGS files. I attached 
my version. I am not completely sure about REPORTING-BUGS, but the HOWTO 
seems to be quite interesting.

3) Does a docbase entry for the HOWTO makes sense? I attached mine. 

4) I used priority optional, since I think this package wouldn't conflict with 
any other package.

5) I added a Suggests: gnuplot since the bash script fio_generate_plots would 
like to have it.

I missed out the examples and your copyright file is better done as well - 
that seems to be the new machine readable format I read about somewhere. Also 
the rules file look interestingly short. cdbs appears to be really nice 
stuff. ;)

I can't do any of above changes myself as I have no write access to that SVN 
repository. I would do any changes that you agree with, Hendrik, otherwise.

Ciao,
-- 
Martin Steigerwald - team(ix) GmbH - http://www.teamix.de
gpg: 19E3 8D42 896F D004 08AC A0CA 1E10 C593 0399 AE90

-------------------------------------------------------

-- 
Martin Steigerwald - team(ix) GmbH - http://www.teamix.de
gpg: 19E3 8D42 896F D004 08AC A0CA 1E10 C593 0399 AE90

Attachment: fio_generate_plots.1
Description: Troff document

fio.1
debian/fio_generate_plots.1
README
HOWTO
REPORTING-BUGS
Document: fio
Title: Flexible I/O tester HOWTO
Author: Jens Axboe
Abstract: This document describes how to run
 the Flexible I/O tester fio and how it works.
Section: Help/HOWTO

Format: text
Files: /usr/share/doc/fio/HOWTO.gz

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: