[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#535691: RFH: munin packaging help



Holger Levsen wrote:
> package: wnpp
> x-debbugs-cc: munin-deb-maint@linpro.no, munin-users@lists.sourceforge.net
>
> Hi,
>
> the munin package could need some more love:
>
> - currently there are 35 open bugs, some with patches, some need to go
>   upstream, etc. - and there is a constant flow of new bugs coming, see
>   see http://people.debian.org/~glandium/bts/m/munin.png
> - the Debian package has 55 patches applied. Few are Debian specific, many
>   have been applied upstream in the 1.3 branch, but some not. Unfortunatly,
>   we dont have an overview about which patch is in which category...
> - munin 1.3 is about to from alpha to beta status and 1.4 might even be 
>   released in time for squeeze. It would be awesome to upload 1.3 to  
>   experimental soon, to get more testing.
> - while uploaders lists five people, most work in the last year has been done
>   by two and most work in the last half year has been done by one person...
>
> If you are interested in helping out, no matter whether you are a DD, DM or 
> not, please contact me or just start working:
>
> - BTS cleanup
> - patch renaming (1xx_* = debian-specific, 2xx_* = applied in 1.3, etc)
> - packaging 1.3
>
>
> Thanks,
> 	Holger
>   

Hi Holger (or anyone interested in helping)

I am not sure I am able to dedicate myself long term to this package,
but I have examined the patches for munin
(http://patch-tracking.debian.net/package/munin/1.2.6-12) and compared
them to munin-trunk (r2285).  I have attached my finding, which mainly
determines which of the patches are still valid.

I may have a look at the source package and implement these changes
later depending on what my sponsor says about my current package.

~Niels




--- Fixed ---
510-fix-bashisms
470-munin-run-man-typo.patch
480-node.d-apache-asterisk.patch
490-node.d-asterisk-if.in
380-munin-graph-utf8.patch
270-Plugin.pm-typo.patch
100-node.d-tomcat_access.patch
330-courier-typo
120-node.d-tomcat_threads.patch
130-node.d-tomcat_volume.patch
200-node-plugins.history.patch
232-ntp_offset.patch
236-nut_misc.patch
381-munin-graph-column-indention.patch
410-muninnodeconf-manpage.patch
450-munin-cgi-graph.patch
520-node.d-nut-plugins

140-node.d-ups_.patch - included as plugins/node.d/nutups_.in

160-node.d-postgres-plugins.patch - included upstream (in folder: node/node.d/)

350-munin-run-usage-fix.patch - suspect it has been rewritten as node/sbin/munin-run which prints a better usage.

211-munin-manpage.patch - included upstream (as: master/doc/munin.pod, builds: build/doc/munin.8)
			- May want to patch it to munin.1

310-node-configure_bugfix - File appears to be (partly) rewritten - the error is handled differently but seems to be  correct.
			  [for reference: node/sbin/munin-node-configure in sub parse_suggest_response line 881-902]

280-if_regex - The context has changed, but it appears to be fixed.


--- Not-fixed plugins ---
  * all plugin patches should change path from "node/node.d..." to "plugins/node.d..."
300-vserver_plugins
150-node.d-openvpn
500-node.d-bind9_rndc-3.5
320-sensors_fix
430-apc_nis-line_volt.patch
360-fw_conntrack-graph_args.patch
260-courier-logtail.patch
233-df_and_df_inode.patch
230-exim_mailqueue.patch
440-node.d.linux-iostat.patch
550-ejabberd-plugin
560-asterisk-plugins

  * Below this point the patches may need some extra modification.
290-postfix_spooldir - NB: The file has been changed.
240-amavis-logtail.patch - NB: The file has been changed.
250-amavis-maillog.patch - NB: The file has been changed.
460-netstat.regex.patch - Regex has been modified (for readability - functionallity does not appear to have changed.)
235-ip_.patch - NB: Half of the patch is now invalid (comments have been replaced with some explaination)
231-exim_mailstats.patch - NB: partly fix, but the "pid removal" for (debian) #440622 is excluded.


--- Not-fixed (other) ---
400-style_css.patch - NB: file moved to master/www
370-plugin-doc-typos.patch - NB: file moved to plugins/lib/Plugin.pm
			   - Partly fix: (2nd entry: "its").



--- May have been fixed satisfiable ---
234-smart_.patch - (now: plugins/node.d/smart_.in) It checks an environment variable to determine whether the extra arguments should be inserted.


--- Needs more checking: ---
460-munin-cgi-graph-mkdir.patch - script looks rewritten / cannot find the context. 
				- NB: file moved to master/_bin/munin-html.in

391-munin-node-ipv6.patch - File seems to have been deleted or rewritten (suspect it is now called node/sbin/munin-node)

390-munin-run-ipv6.patch - File seems to have been deleted or rewritten (suspect it is now called node/sbin/munin-run)

340-nfsd-fix.patch - Rewritten as plugins/node.d.linux/nfsd.in 

220-Makefile.patch - Cannot find the patched code nor its contents. 
		   - Given the structual modifications to the code the patch is probably invalid and is either not required or needs to be "rewritten" from scratch.

210-munindoc-manpage.patch - Makefile: modified - may require some rewriting.
			   - Makefile: munindoc does not appear to be built by default, re-patch
			   - munindoc.in: moved to node/bin/munindoc.in, but changes seems to still be valid.

420-munin-limits.excessive-notifications.patch - Munin.pm does not exist anymore.
					       - munin-limits.in has been renamed to master/_bin/munin-limits.in
					       - Could not find any of the patch contexts in munin-limits.in

530-node.d.linux-cpu-scale-with-HZ - Parts of the patch has been included or it has been rewritten (unsure if it works correctly).
				   - moved to plugins/node.d.linux/cpu.in

540-node.d-acpi-lenny		   - Replaced by plugins/node.d.linux/acpi.in
				   - Seems to have been rewritten from scratch.

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: