Bug#513322: ITP: mupen64plus -- plugin-based N64 emulator
On Sunday 31 May 2009 22:38:44 Felix Arreola Rodriguez wrote:
> Well, I have one package uploaded to mentors.debian.net
> (http://mentors.debian.net/cgi-bin/maintainer-packages?action=details;packa
>ge=mupen64plus).
Please don't add a private link - we don't have access to your profile at
mentors. Better would be a link to
http://mentors.debian.net/debian/pool/non-free/m/mupen64plus/mupen64plus_1.5-2.dsc or
and to
http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=mupen64plus
>But still I need work more time in it. This week I will
> make a better package, I promise.
Ok, the package seems to be pretty unclean. First thing is: if there are
lintian warnings then don't upload it to mentors. Most mentors will look
at them and run away screaming without looking at it further. Please read
http://people.debian.org/~codehelp/#sponsor and the linked requirements of
other sponsors.
Your key seems not to be trusted by many people. You should think about
creating a new one[1] and get some signatures by some debian developers.
With that you can get a debian maintainer[2] and upload new versions of
your packages by yourself. A good idea is to seperate the certification
(main key) from the signatur key. You have currently both in your main
key (see the SC in the usage by calling `gpg --edit-key 223D869A`).
Now to your package. Your tar.gz differs from the one I get from upstream.
Never ever to that without calling your version 1.5+dfsg1-1 instead of
1.5-1 and provide a debian/prune-tarball.sh script. Don't forget to add
information about what and why the package was manipulated.
3747bb55b8dce55afc585b1ccb557297 Mupen64Plus-1-5-src.tar
15f026b6658c7deda1385840d7376065 mupen64plus_1.5.orig.tar
c224b045d343ff02f6f933d328861b01 Mupen64Plus-1-5-src.tar.gz
5c8aac7b0456e04099ba843bc4e484db mupen64plus_1.5.orig.tar.gz
This alone is a reason to ignore your package and never look at it again.
As it seems that you have not changed the files inside the package their
is no reason to create a modified tar.gz. The only change is the name
of the toplevel directory. Please don't do that. dpkg-source is intelligent
enough to do that modification by itself when it unpacks the source package.
So please use the tar.gz from upstream without any modifications if the
source tar.gz doesn't violates the dfsg - otherwise create a dfsg clean
version and rename your version number as told above.
Rename Mupen64Plus-1-5-src.tar.gz to mupen64plus_1.5.orig.tar.gz and replace
your old mupen64plus_1.5.orig.tar.gz with that one. Afterwards rebuild your
package with `debuild -sa` and reupload it to mentors to override the tar.gz
on mentors. This will not work when you uploaded it to the archives.
`lsdiff -z mupen64plus_1.5-2.diff.gz` shows that you modified files outside
of the debian directory. Don't to that. If you need to modify such files then
use patches. A good idea is to use quilt[3] for that.
Your debian directory is really messy. Please remove example files:
$ rm debian/*.ex debian/*.EX
You don't close this bug with "Initial release (Closes: #513322)" in the first
entry of your changelog.
Nobody is interested that this is your first debian package - remove that from
the changelog.
All other entries for 1.5-1 are bogus since the really thing you
did here was the initial release and you don't have other changes since the
initial release - but keep that clean way of changelog entries for future
versions.
README.Debian is not a changelog. Don't use it for such things.
You don't comply with 3.7.3 of the policy - please change read
/usr/share/doc/debian-policy/policy.txt.gz
and
/usr/share/doc/debian-policy/upgrading-checklist.txt.gz
and change the source package - don't forget the Standards-Version in
debian/control.
There is a typing error in the description of the binary package
(M_U_lti)
You tell that you build the gtk version of the packe but don't depend
strictly on it - please remove the " | libqt4-dev" from the build
depends.
Many useless dependencies. Fix the build scripts or read many things
about -Wl,--as-needed (see dpkg-shlibdeps warnings).
You don't have a debian/watch file. Try:
===============================
version=3
opts="uversionmangle=s/-/./" \
http://code.google.com/p/mupen64plus/downloads/list \
http://mupen64plus.googlecode.com/files/Mupen64Plus-(.*).src\.tar.gz
===============================
and test it with `uscan --debug`.
You use debhelper 7 and call `dh_clean -k`. Don't do that. It is
not allowed anymore. Replace this call with `dh_prep` (without the -k).
You are also removing top level directory stamp files with rm.
Please don't do that either. dh_clean will do it for you.
Plugins gets installed in /usr/share, Shouldn't they go to
/usr/lib/mupen64plus (arch dependent files aren't allowed in /usr/share)?
Why does it conflicts with mupen64(-bin)? I cannot find files which
would conflict with it and I doubt that there are runtime conflicts.
The /usr/share/mupen64plus/ is quite big. Try to split the package and
make a mupen64plus-common package which is "Architecture: all"
(one source package for all architectures - only include architecture
independend files only of course).
There is a /usr/share/mupen64plus/doc/ directory. Please move it to
/usr/share/doc/mupen64plus
Don't install the manpage to /usr/man/man1/mupen64plus.1.gz but to
/usr/share/man/man1/mupen64plus.1.gz. Use dh_installman for that
purpose.
Don't install extra license files. Use debian/copyright and link
inside it to the the license files in /usr/share/common-licenses/.
If not available then copy the license text inside debian/copyright.
Copyright has fields which should have been filled in.
Information is missing in copyright file.
Copyright of a file (rom) which seems not to be included is specified.
Your copyright file is old-style. Please convert it to
http://dep.debian.net/deps/dep5/ (dont forget Format-Specification
field).
Font will be installed - this is a non-font package so don't do that.
Depend on ttf-bitstream-vera int the binary package
if you really need that font.
You create the directory /usr/sbin with debian/dirs but dont install
anything to it.
/usr/share/applications/mupen64plus.desktop doesn't follow the
specification (see encoding which is too much).
It is called GTK+ and not GTK (see descriptions).
ricevideo.so embeddeds zlib - please use system zlib instead of the
embedded one.
Differrent other spelling mistakes:
recieved -> received
auxilliary -> auxiliary
usefull -> useful
Config files aren't allowed in /usr. Please install them to /etc
and change the source code accordanly.
The line "* Changed to non-free section,..." is too long (max. 80 chars).
Please use line breaks if a non-header and non-footer line in
debian/changelog is too long.
You are in non-free/games so you must move /usr/bin/mupen64plus to
/usr/games/mupen64plus
"This package was debianed by Félix Arreola (fgatuno.123@gmail.com)" should
not be in in the package description. There are other places (debian/copyright)
with such informations. Your name is also part of the control file - no need
to be extra proud and add it to the description.
I am pretty sure that mupen64plus does not work on all plattforms supported
by debian. Please check if it supports more than i386 and amd64 and change
"Architecture:" in debian/control
You should upload your package to a source version control system and
add Vcs-Browser and Vcs-* field to your debian/control. You can create
a *-guest account on alioth[5] and then join collab-maint[6]. Afterwards
you can create a repository[7]. Git with git-buildpackage and pristine-tar
seems to be a good choice at the moment[8]. This is (not like the rest)
not a must - only a good hint. Another good hint is to search a
co-maintainer for the package and add him as Uploader to debian/control.
You don't provide a menu file for mupen64plus... add one[9] (use
dh_installmenu for the installation by debian/rules).
You aren't using the configure and configure-stamp target in debian/rules.
Remove it then (it isn't needed by anything - and not by the policy).
Remove comments like: "Sample debian/rules that uses debhelper....",
"Add here commands to...", "#docbook-to-man debian/....".
Remove #dh_.... (if it is commented out then it isn't used by you and
this means it is not needed).
Remove unneeded dh_installexamples.
To make it short: too much to do. Please fix everything mentioned above and
then try to reupload a new version of the package to mentors.
I am currently to weary to write more stuff.
[1] http://www.debian-administration.org/users/dkg/weblog/48
[2] http://wiki.debian.org/Maintainers#Uploadingpackages
[3] http://pkg-perl.alioth.debian.org/howto/quilt.html
[4] http://standards.freedesktop.org/desktop-entry-spec/1.0/apc.html
[5] http://alioth.debian.org/
[6] https://alioth.debian.org/projects/collab-maint/
[7] http://wiki.debian.org/Alioth/Arch
http://wiki.debian.org/Alioth/Bzr
http://wiki.debian.org/Alioth/Darcs
http://wiki.debian.org/Alioth/Git
http://wiki.debian.org/Alioth/Hg
[8] http://workaround.org/debian-git-comaintenance
http://honk.sigxcpu.org/projects/git-buildpackage/manual-html/gbp.man.git.buildpackage.html
[9] http://www.debian.org/doc/packaging-manuals/menu.html/
--
Robert Wohlrab
Reply to: