[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#529473: ITP: openoffice.org-altsearch -- Alternative Find and Replace for Writer



Hi,

Rene Engelhard wrote:
> Thorsten Glaser wrote:
> > https://eurynome.mirbsd.org/debs/dists/hardy/wtf/pkgs/openoffice-ext/openoffice.org-altsearch_1.2.2-1~wtf804+1.dsc
> > 
> > This is what we’ll use at work¹ for now; the final version will
> > of course target sid. I think this is also a nice example of
> > how to make a Debian package out of an OOo extension.
> 
> Actually no, it's not. And it has some RC bugs right now even from
> quickly looking at it 

ok, actually they are not that much (it seemed otherwise the first look,
especially )
(and for one thing I remembered wrong)

- Depends: openoffice.org-common

"for Writer". Please depend on writer. (which in turn depends on -common anyway)

- why do you need unzip? Isn't used anywhere.

- s/licence/license/

- please copy the maintainer scripts from already existing extensions.
  Especially the flush_unopkg (by running a list after it was *scheduled*
  to be removed by remove) is important
  This would also add some consistency wrt "Adding Extension foo ..." with
  all the other extensions..

- Looks like #348935 could also be closed with your upload?

- Why do you claim to be a an example for packaging extensions when there
  are alredy others in Debian? 


Grüße/Regards,

René
-- 
 .''`.  René Engelhard -- Debian GNU/Linux Developer
 : :' : http://www.debian.org | http://people.debian.org/~rene/
 `. `'  rene@debian.org | GnuPG-Key ID: 248AEB73
   `-   Fingerprint: 41FA F208 28D4 7CA5 19BB  7AD9 F859 90B0 248A EB73



Reply to: