Bug#523338: ITP: radare -- Free advanced command line hexadecimal editor
AFAIUI sponsor requests should go to debian-mentors. Please not that I'm
not a mentors regular, so I'm not really sure of the exact procedures
here. Nevertheless, I'm copying the mailing list.
Sebastian Reichel <elektranox@gmail.com> writes:
> I am searching for a sponsor, so feel free to do so ;)
My preliminary review of
http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=radare
minor points:
* spurious configure target, please remove it.
* build-target could be improved, e.g. by placing both variants in
different make targets. also consider a VPATH build.
* clean rules unpatches before running clean. This will break if you
had modifications to the clean parts of the build system. You don't
do that here, but I'm mentioning it just in case.
The src/arch directory seems to contain source files of various
licenses, that I believe are part of the created binaries. I therefore
do not think that we can redistribute the radare binary under
GPLv2. E.g.:
- src/arch/dalvik seems to come from the android project, which is
Apache License 2.0. Please note that in debian/copyright.
- src/arch/x86/udis86/* seem to be BSD licensed.
- the files in src/arch/sparc seem to be GPL-3 licensed.
In general, run the tool `devscripts -r .` in the top level root
directory to get a brief license check. AFAIUI this is the tool
ftpmaster uses to examine NEW packages.
I fear debian/copyright needs to mention all this. Are there other
opinions on that from mentors?
--
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4
Reply to: