Bug#504080: ITP: courier-pythonfilter -- filter collection for the Courier MTA
Paweł Tęcza pisze:
frederik@dannemare.net pisze:
It is in pretty good shape, is lintian clean, and I've tested the build
process in an up-to-date sid pbuilder environment as well. I have also added
tiny man pages for pythonfilter and pythonfilter-quarantine as well as
written postinst and prerm scripts for starting and stopping the filter,
plus a few other things. Furthermore, I'm using dpatch to remove "shebangs"
where they are not appropriate.
It sounds very interesting for me. I didn't touch the Python sources,
only packaged them and also created postinst and prerm scripts. I'll
compare your work with mine and write to you, if I have any ideas how to
improve your package.
Hi Frederic,
I've just seen your source package. I very like it. Some things you did
like me, but there are a few differences, for example I didn't know
"trick" with debian/links file. Your work is clean and smart. However I
have the couple comments:
1. Alternative dependency on courier-mta-ssl is probably redundant,
because this package depends on courier-mta.
2. You could add suggestion for python-clamav, python-dns, python-spf
packages. There can be necessary for some Pythonfilter modules.
BTW, do you use Pythonfilter greylisting with PostgreSQL support?
Recently I've been working on it, but no success. Gordon Messmer use
"mysterious" Python pgsql module, but I can't find it in any Debian
Python package for PostgreSQL support.
3. Pythonfilter 1.4 has been released under GPL v3. Please see COPYING
file. I think that it's important notice.
4. You've probably forgotten to add 30_shebang_removal.dpatch file to
debian/patches/00list file.
I've also noticed that all *.dpatch files have 755 permissions, except
of the last patch (30_shebang_removal.dpatch). It has 644.
Unfortunately I don't know nothing about dpatch support for Debian
packaging, so I'm not sure whether executable permission is necessary
for *.dpatch files. But when I'm building the binary backage, then I can
see the warning messages like below:
dpkg-source: warning: executable mode 0755 of
'debian/patches/28_shebang_removal.dpatch' will not be represented in diff
BTW, maybe better idea is to create only one big
00_shebang_removal.dpatch, instead of 30 little files?
5. I have README.Debian file with the following content. Feel free to
copy/modify it, if you think that it can be helpful for users.
courier-filter-python for Debian
--------------------------------
pythonfilter is ready to work after installation, but all its filters
are disabled by default. Please edit /etc/pythonfilter.conf file
and enable the filters you need. For some of them you also need to edit
/etc/pythonfilter-modules.conf file.
Next edit /etc/courier/enablefiltering file and enable mail sources
which you want to filter.
Now you are ready to courierfilter restart:
sudo courierfilter restart
Note: If you were not using any Courier mail filters (i.e. dupfilter
or perlfilter) before, then you should modify your system boot script
to run courierfilter start as soon as possible, and run courierfilter stop
during the final portion of your system shutdown script.
-- Paweł Tęcza <ptecza@net.icm.edu.pl> Tue, 09 Dec 2008 12:02:13 +0000
That's all :)
I guess you don't want to rename your package? ;)
Have a nice day,
Pawel
Reply to: