[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#449098: ITP: natpmp -- NAT Port Mapping daemon



Adrian,

In my humble opinion, the init script is a complete failure.

The reasons are:
- you must never control the server firewall, it's the administrative
  task only, i.e. admin has to create the chain he wants, add the jump
  in the place he wants and pass the chain name through default file;
- in case when $VERBOSE is 'no', the form
    [ "$VERBOSE" != no ] && ||
  goes for else branch, if the branch is absent then $? of the whole
  form is !true. So, if this form is the last statement in, for example,
  the case variant, then the whole case returns !true. Which
  subsequently leads to the script failure from invoke-rc.d's point of
  view.

Please update the script considering the above.

-- 
Eugene Paskevich             |   *==)-----------   |     Plug me into
eugene@raptor.kiev.ua        |   -----------(==*   |      The Matrix



Reply to: