[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#470091: ltp package in Debian



On Fri, 12 Sep 2008 19:37:13 +0200, Riku Voipio <riku.voipio@iki.fi> wrote:

On Fri, Sep 12, 2008 at 05:47:21PM +0200, Jiří Paleček wrote:
if you're still interrested, I've uploaded my package to

http://mentors.debian.net/debian/pool/main/l/ltp

Looks fine to me. Some minor issues:

1) the changelog is missing "closes: 470091" text to close this
bug (ltp being orphaned). Simillary you'll need to close the
"new upstream version available bug" in changelog.

2) add Vcs-Git: git://repo.or.cz/ltp-debian.git and Vcs-Browser:
http://repo.or.cz/w/ltp-debian.git tags to debian/control

3) likewise, a Homepage: http://ltp.sourceforge.net/

4) you have commented out most of debian/rules and replaced
it all with cdbs. Since you are already using git, you could
just _remove_ the commented lines - they can still be found
from git history. This would make the debian/rules file shipped
in the package cleaner.

Generally good work, its miles ahead of what the _current_
ltp packages in debian are. Once you've fixed atleast the changelog,
I'm ready to upload it.

Ok, I uploaded a new version to mentors.debian.net (same URL).

There's a lintian warning about the watch file I added (unmangled debian version), but I think it is a false positive, because I have

opts=dversionmangle=s/\+.*$// \
http://sf.net/ltp/ltp-full-([0-9]+)\.tgz debian git-import-orig

in the watch file, which should mangle the debian version correctly.

Regards
    Jiri Palecek



Reply to: