[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#492477: Notes about the loggerhead package



Hi Jelmer,

here some notes I made while reviewing the loggerhead package:

 - it installs a conffile /etc/loggerhead.conf. After having a short
   look at it, it seems to me that for almost every usecase, the user is
   expected to edit this file. This means that on every upgrade where we
   edit the default config, a conffile change will happen. I don't think
   this is really what we want.

   How about shipping the default config in
   /usr/share/doc/loggerhead/example.conf and guide the user in a
   README.Debian file to copy it manually to /etc/loggerhead.conf? He
   needs to adapt the file anyways. This way we can also get rid of that
   /etc/default/loggerhead file. The initscript could then just check
   for the presence of /etc/loggerhead.conf and be done with it.

 - init script. The dependencies in loggerhead currently state this:

# Required-Start:    $remote_fs $syslog
# Required-Stop:     $remote_fs $syslog

  I'm not sure if this is right. The source does not reference syslog
  anywhere, moreover, AFAIUI loggerhead requires the network to be
  up. Therefore I suggest "$local_fs $remote_fs $network" instead
  (inspired by the apache2 init script)

 - any particular reason to upload to experimental? I propose uploading
   to unstable instead. Sure, it won't make it for the lenny release,
   but unless it is in an highly experimental state that we don't want
   'regular' users to use and test it, I see no reason to 'hide' it in
   experimental.

Please comment on the 3 points above and indicate if you agree or
disagree. I'll go on with uploading when we sort these changes out.

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4



Reply to: