On Tue 2008-05-20 23:09:02 -0400, Daniel Kahn Gillmor wrote:
> On Tue 2008-05-20 15:32:38 -0400, Daniel Kahn Gillmor wrote:
>
>> FWIW, i'm down to only 4 errors (all "different width due to
>> prototype") using the warning flags Jörg suggested, so i'm
>> relatively close to a "cleanup" patch i can send upstream.
>
> I've also committed the changes that leave me with only 4 build
> warnings (these would go upstream, hopefully, but could also be
> released with a new debian revision if you think that's preferable).
After banging my head against these last 4 errors for a while, i
researched the warning i was seeing itself.
The warnings were:
gcc -g -O2 -Wformat=2 -Wunused -Wundef -Wextra -Wswitch-enum -Wshadow -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings -Wconversion -Wbad-function-cast -Wnested-externs -Wall `pkg-config --cflags x11 xtst 2> /dev/null || echo "-I/usr/X11R6/include -I/usr/local/include"` -c xdo.c
xdo.c: In function ‘xdo_type’:
xdo.c:276: warning: passing argument 2 of ‘_xdo_keycode_from_char’ with different width due to prototype
xdo.c:277: warning: passing argument 2 of ‘_xdo_get_shiftcode_if_needed’ with different width due to prototype
xdo.c: In function ‘_xdo_populate_charcode_map’:
xdo.c:394: warning: passing argument 2 of ‘XKeycodeToKeysym’ with different width due to prototype
xdo.c: In function ‘_xdo_keysequence_to_keycode_list’:
xdo.c:476: warning: passing argument 2 of ‘__strtok_r_1c’ with different width due to prototype
After reading a recent post on cocoa-dev [0], i no longer think these
warnings are relevant. In fact, i think that -Wconversion is
basically a lot of false positives: the compilers in debian (and every
other OS i've used in the last decade) can all handle function
prototypes just fine, thanks.
Without -Wconversion, my current svn HEAD builds with no errors, so
i'm going to ship the cleanup diff upstream to see if Jordan's
interested.
--dkg
[0] http://lists.apple.com/archives/cocoa-dev/2008/May/msg00923.html
Attachment:
pgpLF5hPzuutz.pgp
Description: PGP signature