Bug#469906: debian : RFS flashblock
On 2008-04-26 Philippe Coval <rzr@users.sf.net> wrote:
> Let me update this bug status,
> I published a source package at :
> http://mentors.debian.net/debian/pool/main/f/flashblock/
> Sponsorship/Upload is welcome too :
> http://mentors.debian.net/cgi-bin/maintainer-packages?action=details;package=flashblock
Hello,
Thanks for your efforts.
I have taken a short look at the package. This is the first
mozilla-pugin source package I have taken a look at, I am not familiar
with the best-practices. - Eyeing example packages (venkman) there
seems to be some black magic involved, like writing a chrome.d file
and generating the correct symlinks in {/usr/share,/var/lib}. Which i
why I do not intend to sponsor this.
Anyway, I think the following might still be helpful.
There are a couple of things that probably need to be fixed:
#1 The version number. You (claim to) have taken a svn snapshot and
labeled it 1.3.9a.
This is going to make problems if you ever want to upload the
released version of 1.3.9:
-------------
ametzler@argenau:/tmp/$ dpkg --compare-versions 1.3.9a-1 \
'<=' 1.3.9-1 || echo beta version sorts after release
beta version sorts after release
-------------
1.3.9~svn20080307-1 (with 20080307 being the checkout date) would sort
correctly and would correctly label this as svn-snapshot.
#2 The generation of orig.tar.gz. Please document exactly and in
detail how the orig.tar.gz was generated in debian/README.source. This
should show how to package a released version (using the .xpi as
input), too.
#3 There is no seamonkey package in Debbian, you probably should
depend on iceape-browser instead. (Not that the package currently
works with iceape-browser, there is a magic symlink or chrome.d file
missing somewhere.)
cu andreas
--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'
Reply to: