[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#468418: cropper compatibility



On Thu, Apr 10, 2008 at 07:24:27PM -0300, Marcelo Jorge Vieira (metal) wrote:

> I made the jscropperui[0] package and
> I'm now waiting for some sponsor to upload the package.
> (I've just sent an email to Daniel asking if he could be the sponsor.)
> 
> 
> I've tested the package and it has none incompatibility =D

I'm a bit surprised because I was browsing the prototype changelog at

 http://dev.rubyonrails.org/browser/spinoffs/prototype/tags/rel_1-6-0-2/CHANGELOG

and noticed at least this:

355       !! BACKWARDS COMPATIBILITY CHANGE !!
356      
357       If you have code that looks like this:
358         $('id').setStyle({'font-size': '12px'});
359       You need to replace it with either of the following:
360         $('id').setStyle({fontSize: '12px'});
361         $('id').setStyle('font-size: 12px;');

which seems to match these:

cropper.uncompressed.js:        $( this.imgWrap ).setStyle( { 'width': this.imgW + 'px', 'height': this.imgH + 'px' } );
cropper.js:$(this.imgWrap).setStyle({"width":this.imgW+"px","height":this.imgH+"px"});

But maybe it's just about the 'font-size' attribute and not a general
syntax change? (I don't really know anything about javascript, which is
why I'm so glad for others to handle these libraries.)

Cheers,
-- 
Niko Tyni   ntyni@debian.org



Reply to: