Bug#456227: Notes on this package
I have fixed most of these things... (might have missed one or two) and
uploaded to mentors.debian.net...
Micah Anderson wrote:
> I've reviewed this package and made some notes on things that
> I think need to be changed before it can be uploaded to the
> archive. I previously sent these directly to Monty, but for
> posterity, I am re-sending to the ITP bug here.
>
>>> I can offer sponsorship of this package if you need it.
>> That would actually be nice. I've got packaging up and usable on
>> launchpad. If you'd like to look at it:
>> https://launchpad.net/~pkg-sphinx/+archive
>
> I cannot sponsor for ubuntu, but for debian I can.
>
> I was able to pull the source package and am taking a look at it.
>
>> Otherwise, let me know where to stick them and I'll make a new source
>> package that's actually targeted at Debian.
>
> Have you given much thought about how you are wanting to maintain both
> an ubuntu and debian package? There are going to be differences in both
> and perhaps you will want a different branch in the SCM? I'm new to
> launchpad and bzr, but it looks like there is just a trunk branch at the
> moment (correct me if I am wrong).
>
> If you want to create debian specific packags, and separate development
> completely, you could create an alioth account to get a SCM repository
> in Debian land. But if you just want to make a different branch in the
> existing launchpad bzr for Debian, you could upload the debian-specific
> package to http://mentors.debian.net, or just put it somewhere that I
> can get at it.
>
>> I need to update this to a later version - but this would be ok for now
>> I think.
>
> If there is a newer version available, lets do that at the same time,
> probably best to get the latest and greatest in all at once, no?
> Although, it looks like you've been pulling from the SVN trunk, and the
> Sphinx page says that r1112 is pretty much a release, except for out of
> date documentation.
>
> Specific notes on the package:
>
> . README.Debian needs to be filled out
>
> . the version numbers in the changelog are long and ubuntuy, but I think
> it makes sense to denote the svn revision, maybe change those to debian
> in the debian branch (version 0.9.8-0u buntu3~svn985 has a space in the
> version number, which is not legal... maybe you want to fix that?)
>
> . The Vcs, Homepage, and Browser debian/control fields would have to be
> changed if you made a different branch for debian
>
> . I know the upstream home page has as their description of Sphinx "Free
> open-source SQL full-text search engine", but what about changing it to
> be a little more descriptive, such as, "Fast standalone full-text SQL
> search engine" or similar? The "Free open-source" part of the
> description is what gets me...
>
> . Longer description shouldn't reference the license in the first
> paragraph, just cut that first part out. In the second paragraph,
> instead of using the project text verbatum, maybe change "Generally," to
> be "Sphinx search is a standalone..." and change the last paragraph just
> to be, "Sphinx is an acronym which is officially decoded as SQL Phrase
> Index." and get rid of the "Yes, I know..." part (its a little glib for
> a package description). The doc/sphinx.txt has some good additional
> information that might be worth including (in the About and Features
> sections), but you do want to keep things not too long
>
> . I made a couple minor cosmetic changes to debian/rules, I've attached
> a diff to this email
>
> . I notice that there is a daemon (searchd), but you are not providing
> an initscript for it, there should be one created and it should be
> named after the package (perhaps a cronjob is needed as well?)
>
> . libmysqlclient-dev is only in experimental right now, can this use
> libmysqlclient15-dev until that is available in sid?
>
> . the /bin/bash bootstrap in the rules is something that is weird, first
> of all it is not a bash script at all, and you aren't build-depending on
> bash, so you probably shouldn't include it. It would be better to have
> an autotools: build target in debian/rules that maybe did that if you
> needed to run it.
>
> The sphinx.conf file. There isn't one being generated with some sane
> defaults and put into /etc/sphinx.conf (perhaps considering putting
> some defaults in /etc/defaults/sphinxsearch?).
>
> This filename might cause some problems, because of the package name,
> but it shouldn't be a big deal for now, but it might be worthwhile
> to make things be in /etc/sphinxsearch/sphinx.conf.
>
> The config also has /var/log/searchd.log created, maybe that should be
> /var/log/sphinxsearch.log, or maybe /var/log/sphinxsearch/searchd.log
> would be better.
>
> The default location for the PID file in the config is:
> @CONFDIR@/log/searchd.pid
>
> That should be /var/run/searchd.pid
>
> I do notice however that /var/lib/sphinx-search is created, when that=20
> probably should be /var/lib/sphinxsearch to correspond to the package name.
> Also /var/lib/sphinxsearch/data should be created, as that is used.
>
> I hope this isn't all overwhelming!
>
> Micah
>
Reply to: