Hi Daniel,
I've built your package successfully on PowerPC and it works.
But some comments from me:
· Are root privileges really necessary to clean up the directory? You
should drop dh_testroot from the clean target. It's annoying to call
debian/rules clean with fakeroot.
· Your build target is not a real target nor does it depend on one. So
every request for binary-arch triggers a rebuild. That's caught be the
upstream makefile and should not bother on this small package. But only
as a hit, you should make build depend on xdotool, the only binary in
your package. Bigger packages create empty files (stamps) for this.
· The example doesn't get installed. Is this intended? It contradicts the
dh_installexample call in rules.
· Why does binary-indep denpend on build and install? You should leave it
empty.
· Why did you put the install commands in a separate target?
· There's no configure target, but you name it in .PHONY.
· You should support noopt; Policy 10.1.
· When building with CFLAGS=-Wformat=2 -Wunused -Wundef -Wextra
-Wswitch-enum -Wshadow -Wpointer-arith -Wcast-qual -Wcast-align
-Wwrite-strings -Wconversion -Wbad-function-cast -Wnested-externs
I get warnings about the code; see below. Can you tell the upstream
programmer to fix them?
Sorry, but I'm not a DD. I can't sponsor your package, but I wish you
good luck to find someone.
Bye, Jörg.
dh_testdir
/usr/bin/make
make[1]: Entering directory `/tmp/xdotool-20071230'
gcc -O2 -Wall -Wformat=2 -Wunused -Wundef -Wextra -Wswitch-enum -Wshadow -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings -Wconversion -Wbad-function-cast -Wnested-externs -Wall `pkg-config --cflags x11 xtst 2> /dev/null || echo "-I/usr/X11R6/include -I/usr/local/include"` -c xdotool.c
xdotool.c: In function ‘cmd_help’:
xdotool.c:101: warning: unused parameter ‘argc’
xdotool.c:101: warning: unused parameter ‘args’
xdotool.c: In function ‘cmd_windowmove’:
xdotool.c:257: warning: passing argument 2 of ‘xdo_window_move’ as signed due to prototype
xdotool.c: In function ‘cmd_windowfocus’:
xdotool.c:274: warning: passing argument 2 of ‘xdo_window_focus’ as signed due to prototype
xdotool.c: In function ‘cmd_windowraise’:
xdotool.c:291: warning: passing argument 2 of ‘xdo_window_raise’ as signed due to prototype
xdotool.c: In function ‘cmd_getwindowfocus’:
xdotool.c:408: warning: negative integer implicitly converted to unsigned type
xdotool.c:418: warning: dereferencing type-punned pointer will break strict-aliasing rules
xdotool.c: In function ‘cmd_windowmap’:
xdotool.c:437: warning: passing argument 2 of ‘xdo_window_map’ as signed due to prototype
xdotool.c: In function ‘cmd_windowunmap’:
xdotool.c:454: warning: passing argument 2 of ‘xdo_window_unmap’ as signed due to prototype
gcc -O2 -Wall -Wformat=2 -Wunused -Wundef -Wextra -Wswitch-enum -Wshadow -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings -Wconversion -Wbad-function-cast -Wnested-externs -Wall `pkg-config --cflags x11 xtst 2> /dev/null || echo "-I/usr/X11R6/include -I/usr/local/include"` -c xdo.c
In file included from xdo.c:23:
xdo_util.h:8: warning: initialization discards qualifiers from pointer target type
xdo_util.h:8: warning: initialization discards qualifiers from pointer target type
xdo_util.h:9: warning: initialization discards qualifiers from pointer target type
xdo_util.h:9: warning: initialization discards qualifiers from pointer target type
xdo_util.h:10: warning: initialization discards qualifiers from pointer target type
xdo_util.h:10: warning: initialization discards qualifiers from pointer target type
xdo_util.h:11: warning: initialization discards qualifiers from pointer target type
xdo_util.h:11: warning: initialization discards qualifiers from pointer target type
xdo_util.h:12: warning: initialization discards qualifiers from pointer target type
xdo_util.h:12: warning: initialization discards qualifiers from pointer target type
xdo_util.h:13: warning: initialization discards qualifiers from pointer target type
xdo_util.h:13: warning: initialization discards qualifiers from pointer target type
xdo_util.h:18: warning: initialization discards qualifiers from pointer target type
xdo_util.h:19: warning: initialization discards qualifiers from pointer target type
xdo_util.h:20: warning: initialization discards qualifiers from pointer target type
xdo_util.h:21: warning: initialization discards qualifiers from pointer target type
xdo_util.h:22: warning: initialization discards qualifiers from pointer target type
xdo_util.h:23: warning: initialization discards qualifiers from pointer target type
xdo_util.h:24: warning: initialization discards qualifiers from pointer target type
xdo_util.h:25: warning: initialization discards qualifiers from pointer target type
xdo_util.h:26: warning: initialization discards qualifiers from pointer target type
xdo_util.h:27: warning: initialization discards qualifiers from pointer target type
xdo_util.h:28: warning: initialization discards qualifiers from pointer target type
xdo_util.h:29: warning: initialization discards qualifiers from pointer target type
xdo_util.h:30: warning: initialization discards qualifiers from pointer target type
xdo_util.h:31: warning: initialization discards qualifiers from pointer target type
xdo_util.h:32: warning: initialization discards qualifiers from pointer target type
xdo_util.h:33: warning: initialization discards qualifiers from pointer target type
xdo_util.h:34: warning: initialization discards qualifiers from pointer target type
xdo_util.h:35: warning: initialization discards qualifiers from pointer target type
xdo_util.h:36: warning: initialization discards qualifiers from pointer target type
xdo_util.h:37: warning: initialization discards qualifiers from pointer target type
xdo_util.h:38: warning: initialization discards qualifiers from pointer target type
xdo_util.h:39: warning: initialization discards qualifiers from pointer target type
xdo_util.h:40: warning: initialization discards qualifiers from pointer target type
xdo_util.h:41: warning: initialization discards qualifiers from pointer target type
xdo_util.h:42: warning: initialization discards qualifiers from pointer target type
xdo_util.h:43: warning: initialization discards qualifiers from pointer target type
xdo_util.h:44: warning: initialization discards qualifiers from pointer target type
xdo_util.h:45: warning: initialization discards qualifiers from pointer target type
xdo_util.h:46: warning: initialization discards qualifiers from pointer target type
xdo_util.h:47: warning: initialization discards qualifiers from pointer target type
xdo_util.h:48: warning: initialization discards qualifiers from pointer target type
xdo_util.h:49: warning: initialization discards qualifiers from pointer target type
xdo_util.h:50: warning: initialization discards qualifiers from pointer target type
xdo_util.h:51: warning: initialization discards qualifiers from pointer target type
xdo_util.h:52: warning: initialization discards qualifiers from pointer target type
xdo.c: In function ‘xdo_new_with_opened_display’:
xdo.c:74: warning: assignment discards qualifiers from pointer target type
xdo.c: In function ‘xdo_window_map’:
xdo.c:101: warning: passing argument 2 of ‘XMapWindow’ as unsigned due to prototype
xdo.c: In function ‘xdo_window_unmap’:
xdo.c:108: warning: passing argument 2 of ‘XUnmapWindow’ as unsigned due to prototype
xdo.c: In function ‘xdo_window_move’:
xdo.c:172: warning: passing argument 2 of ‘XConfigureWindow’ as unsigned due to prototype
xdo.c: In function ‘xdo_window_setsize’:
xdo.c:188: warning: passing argument 2 of ‘XGetWMNormalHints’ as unsigned due to prototype
xdo.c:208: warning: passing argument 2 of ‘XConfigureWindow’ as unsigned due to prototype
xdo.c:208: warning: passing argument 3 of ‘XConfigureWindow’ as unsigned due to prototype
xdo.c: In function ‘xdo_window_focus’:
xdo.c:215: warning: passing argument 2 of ‘XSetInputFocus’ as unsigned due to prototype
xdo.c: In function ‘xdo_window_raise’:
xdo.c:223: warning: passing argument 2 of ‘XRaiseWindow’ as unsigned due to prototype
xdo.c: In function ‘xdo_mousedown’:
xdo.c:245: warning: passing argument 2 of ‘XTestFakeButtonEvent’ as unsigned due to prototype
xdo.c: In function ‘xdo_mouseup’:
xdo.c:252: warning: passing argument 2 of ‘XTestFakeButtonEvent’ as unsigned due to prototype
xdo.c: In function ‘xdo_type’:
xdo.c:277: warning: passing argument 2 of ‘_xdo_keycode_from_char’ with different width due to prototype
xdo.c:278: warning: passing argument 2 of ‘_xdo_get_shiftcode_if_needed’ with different width due to prototype
xdo.c:281: warning: passing argument 2 of ‘XTestFakeKeyEvent’ as unsigned due to prototype
xdo.c:282: warning: passing argument 2 of ‘XTestFakeKeyEvent’ as unsigned due to prototype
xdo.c:283: warning: passing argument 2 of ‘XTestFakeKeyEvent’ as unsigned due to prototype
xdo.c:285: warning: passing argument 2 of ‘XTestFakeKeyEvent’ as unsigned due to prototype
xdo.c: In function ‘_xdo_keysequence_do’:
xdo.c:306: warning: passing argument 2 of ‘XTestFakeKeyEvent’ as unsigned due to prototype
xdo.c: In function ‘_xdo_populate_charcode_map’:
xdo.c:393: warning: declaration of ‘index’ shadows a global declaration
/usr/include/string.h:310: warning: shadowed declaration is here
xdo.c:394: warning: passing argument 2 of ‘XKeycodeToKeysym’ with different width due to prototype
xdo.c: In function ‘_keysym_to_char’:
xdo.c:408: warning: negative integer implicitly converted to unsigned type
xdo.c:419: warning: negative integer implicitly converted to unsigned type
xdo.c: In function ‘_xdo_get_child_windows’:
xdo.c:443: warning: comparison between signed and unsigned
xdo.c: In function ‘_xdo_keysequence_to_keycode_list’:
xdo.c:476: warning: passing argument 2 of ‘__strtok_r_1c’ with different width due to prototype
xdo.c:493: warning: passing argument 2 of ‘XKeysymToKeycode’ as unsigned due to prototype
xdo.c:503: warning: passing argument 2 of ‘realloc’ as unsigned due to prototype
gcc -O2 -Wall -Wformat=2 -Wunused -Wundef -Wextra -Wswitch-enum -Wshadow -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings -Wconversion -Wbad-function-cast -Wnested-externs -Wall `pkg-config --cflags x11 xtst 2> /dev/null || echo "-I/usr/X11R6/include -I/usr/local/include"` `pkg-config --libs x11 xtst 2> /dev/null || echo "-L/usr/X11R6/lib -L/usr/local/lib -lX11 -lXtst"` xdotool.o xdo.o -o xdotool
make[1]: Leaving directory `/tmp/xdotool-20071230'
--
Life can only be understood backwards, but it must be lived forwards.
(Soren Kierkegaard)
Attachment:
signature.asc
Description: Digital signature