On Fri, Nov 16, 2007 at 10:31:06AM +0000, Simon McVittie wrote: > > I already packaged this in Ubuntu. Feel free to adopt it for Debian. > Having looked at the Ubuntu packaging, I'm somewhat concerned about it > - it seems you don't have the changes I made in upstream bzr to make > gfsplit cryptographically safe. No, I wasn't aware of such changes. > The patch to gfcombine to support "-" as meaning standard output looks > reasonable, but I'm not sure what it's doing in Ubuntu but not > upstream... perhaps we could get that in 1.0.3. The patch is: The patch should definitely have been sent upstream. My apologies. I wrote it while on a train, and when I got near internet access again, I had forgotten all about it. I suck. > although I'd be inclined to change it to just use stdout instead of > fdopening STDOUT_FILENO, Makes sense. I can't remember why I did it that way, tbh. > and make the indentation consistent (the rest of the package > consistently uses 2 spaces, the "else" clause in the patch has a tab). Good catch. -- Soren Hansen Ubuntu Server Team http://www.ubuntu.com/
Attachment:
signature.asc
Description: Digital signature