[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#450909: incorrect information in debian/copyright



Daniel Kahn Gillmor wrote:
> Thanks!  I welcome any other suggestions you have about the tool,
> From a packaging perspective or otherwise.

Some further comments on 0.4-1:

    # FIXME: if there's no ip and no ifconfig, what do we do?
    verify_interface() {
        if [ -x /bin/ip ] ; then
        /bin/ip link show "$1" >/dev/null
        elif [ -x /sbin/ifconfig ] ; then
        /sbin/ifconfig -s "$1" > /dev/null
        else
        error "Don't know how to test interface.  Assuming '$1' is acceptable."
        true
        fi
    }

I'd put a Recommends on net-tools (for /sbin/ifconfig).

Also, exchange the binary-indep and binary-arch targets in debian/rules.
This package doesn't build any arch-dependent packages, so binary-arch
should do nothing.

-- 
Robert Edmonds
edmonds@debian.org

Attachment: signature.asc
Description: Digital signature


Reply to: