Bug#398198: Diff for version 0.0.6

[Loïc Minier <lool@dooz.org>]

        Hi,

On Thu, Mar 01, 2007, Marc-André Lureau wrote:
> Loic, would you help me? I have other ITP with packaging ready.

 I'm afraid I took terribly long to reply; sorry about that.

 Anyway, here's a review of your proposed diff:
 - debian/dirs is useless, you can drop it; it also creates a spurious
   usr/sbin in the valac package
 - it's good style to avoid passing --host if DEB_BUILD_GNU_TYPE equals
   DEB_HOST_GNU_TYPE, you can do this with:
ifeq ($(DEB_BUILD_GNU_TYPE),$(DEB_HOST_GNU_TYPE))
        configure_flags += --build=$(DEB_BUILD_GNU_TYPE)
else
        configure_flags += --build=$(DEB_BUILD_GNU_TYPE) --host=$(DEB_HOST_GNU_TYPE)
endif
   or equivalent.
 - it's usual to install to debian/tmp while you install to debian/vala;
   not a problem in itself, but slightly uncommon, and you can save
   yourself the "rm -rf $(CURDIR)/debian/vala" in this case since
   dh_clean will "rm -rf debian/tmp"
 - please don't ship *.la files, these cause superfluous link flags
   later on (due to dependency_libs which pulls everything recursively)
   and are hard to remove later on
!- you should update the short descriptions to be different dor each
   package, for example you could add "- shared library" at the end of
   the libvala0 short description
!- you should match the version of your libglib2.0-dev build-dep to the
   version in configure.ac; this is especially useful for backports
!- the libtool build-dep isn't needed
!- the headers shipped in the -dev package have some glib.h and
   glib-object.h includes, so you need to depend on libglib2.0-dev
!- the pkg-config file "Requires" glib and gobject, this is another
   reason to depend on libglib2.0-dev
!- you need a strict dependency of libvala0-dev on libvala0, usually "(=
   ${Source-Version})" is used
!- unless there's a reason not to do so, I think you should name the
   -dev lib "libvala-dev", not libvala0-dev
!- the Section and Priority fields in your control are not completely
   correct; you should use "optional" Priority, unless you have a reason
   to use "extra"; you should use Section: libs for libvala0 and
   libdevel for libvala-dev (devel is ok for valac and by default)

 Minor upstream note: I'm puzzled by the "AC_PATH_PROG(VALAC, valac,
 valac)" in configure.ac, but the AC_SUBST(VALAC) afterwards isn't
 needed.

 Despite the number of above remarks, your package is in a relatively
 good initial shape!

 Please fix the items marked with "!" above (or answer to them) and I'll
 probably consider your package to be uploadable!

   Bye,
-- 
Loïc Minier