Bug#405122: ITP: ocamlwc -- count the lines of code and comments in OCaml sources
Georg Neis wrote:
> Hello Daniel,
> thanks for your comments!
welcome. btw, in case you send a private mail (in future or so), german
would work too :)
> * Daniel Baumann <daniel@debian.org> wrote:
>> * tipp: debhelper (>> 4.0.0) is over-precise,
>> debhelper (>= 4) is just enough.
>
> Changed. (Out of curiosity, does it make a difference?)
not really.
>> * should: since you wrote ocamlwc.1 yourself,
>> you should structure it like the more common
>> examples, incl. adding a AUTHOR section.
>> look at gproftpd for a sane example.
>
> I think the manpage is quite standard (in particular, it doesn't invent
> any section names). If I'm going to add an AUTHOR section, then I would
> prefer to only mention the author of the software itself:
> Nobody cares about who wrote the manpage. Besides, I don't want to
> claim that I *wrote* it, since I just took the program's usage message
> together with some roff macros and added two lines.
>
> What do you think?
if you don't want to have your name as the author in it, i'm fine with
that, it's your decision. i just mentioned it in case you may have
forgotten it.
unrelated to that, don't forget to send the manpage upstream, so that it
will hopefully included in the next upstream release.
>> * must: instead of patch, you should use patch-stamp in rules.
>
> Why? dpatch.make(7) says:
> Using dpatch.make is rather straightforward: one has to include
> the file in debian/rules, change the appropriate targets to depend on
> patch and unpatch, and that is all it takes.
> In fact, in /usr/share/dpatch/dpatch.make, the patch target depends on
> patch-stamp.
excately. patch depends on patch-stamp, so why not call patch-stamp
directly? ;)
> Another question. The Debian OCaml Policy (section 2.2) says:
>
> A bytecode package must build-depend-indep on ocaml-nox-3.09.2 (or
> ocaml-3.09.2 if the program either uses the Graphics or the LablTk
> module). The current version number of OCaml should not be hardcoded
> into the build-dependency (this is a deviation from a practice which
> used be recommended but is depreciated now). Of course, if it is
> necessary to ensure that the version of OCaml has a certain value then
> version constraints can be used. However, this should be justified by
> the requirements of the compilation of the program.
>
> This is not clear to me. It says I should build-depend-indep on
> ocaml-nox-3.09.2. However, wouldn't this mean "hardcoding the current
> version number of OCaml into the build-dependency"?
> Currently, I just have "Build-Depends-Indep: ocaml-nox".
some packages do have a versioned depends, such as "ocaml-nox (>=
3.09.2)", but the ocaml policy says to have a "ocaml-nox-3.09.2"
depends. ocaml-nox-3.09.2 is a virtual package provided by the current
ocaml-nox package.
tell me when you adjusted it, so i'll have a look at it again and upload it.
--
Address: Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email: daniel.baumann@panthera-systems.net
Internet: http://people.panthera-systems.net/~daniel-baumann/
Reply to: