On 11/6/06, Alan Woodland <ajw05@aber.ac.uk> wrote:
I've had another quick look, and I've got a few comments:
Firstly you say "Architecture: any". Did you really mean this? I think
this should be ok as an "Architecture: all" package, since nothing
changes between any two architectures? If this is the case then using
all instead of any saves archive space, and buildd time.
done. I have changed Architecture to all.
Secondly your manpage points people to documentation on the internet.
Some people might complain about this. Although as flickrfs is an online
tool, this complaint is somewhat reduced it may still be worth including
an offline copy of the documentation with the package. Additionally the
manpage doesn't actually say anything more than the long description
does really. Can you add some more precise documentation about how to
get started using it there? How to mount the filesystem or configure it?
Ok, this time I have written a detailed manpage. I have almost tried to
reproduce the html documentation :-)
Thirdly I'm not massively keen on the long description as it stands. See
the long description in
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=378226 and the
associated comments on it.
I have changed the long description and made it more elaborate.
Fourthly your copyright file states:
It was downloaded from <
http://varun.travisbsd.org/debian_packages/flickrfs/>
This should be the URL for the original version, e.g. in this case http://manishrjain.googlepages.com/flickrfs
Well, I actually have compiled this source. I mean, version 1.3 is not available at Manish's homepage. I have made some changes in the source file, changed the directory structure, added extra files like
setup.py and COPYING.
So, now I have two options, either I ask upstream to consider releasing my source as a new version or I maintain a separate source to build debian package.
Currently this source package is only available on my Homepage so I specified that URL in copyright.
Finally I think the package should recommend imagemagick, and possibly (although I'm not 100% sure) depend on fuse-utils.
Now, I have added python-fuse in build-depends which in turn depends on fuse-utils. So that should work.
Other than that things seem in order as far as I can see.
Please have a look at the package now. Suggestions are welcome.