[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#354460: RFS: fatresize - Command line tool for resizing of FAT16/FAT32 file systems



Daniel Baumann wrote:
> i will look at your package in about one or two hours..

here we go:

  * changelog has a useless empty line at the end of the file.

  * this:

---snipp---
libparted1.7-dev , docbook-to-man , docbook-utils
---snapp---

should be

---snipp---
libparted1.7-dev, docbook-to-man, docbook-utils
---snapp---

    note the spaces.

  * ${misc:Depends} is useless here.

  * please enhance the long description a bit, and please
    don't clutter it - wrapp after 80chars and not earlier,
    or, make use of paragraphs.

  * debian/copyright is not good, look at libquicktime from
    experimental for a sane example.

  * debian/dirs is not needed, the build system creates those
    directories on its own.

  * the docs you want to install through debian/docs do not
    contain any usefull information, remove it.

  * Add the examples from the README to the manpage.

  * cleanup your rules:

    - remove the useless commented stuf
    - don't use two-empty-lines as seperator, one is just enough.

  * remove the empty lines at the end of debian/watch.

if you fix the things mentioned above, i'll sponsor your package.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/



Reply to: