Bug#263826: waiting for sponsor
there are quite a few things to be done, but first of all:
please do upload the package somewhere where directory listing is
enabled. if you've no other possibility, you can also make use of
mentors.debian.net of course.
now to the package:
* rebuild it on and for sid, sarge is not developed anymore, only
security updates. do functional tests on sid too.
* debian/changelog contains a useless empty-line at the end of the
file.
* debhelper (>= 4.0.0) is over-precise, debhelper (>= 4) is just
enough.
* don't write versioned depends like this: foo (>=1.2.3)
but like this instead: foo (>= 1.2.3)
(note the space)
* don't depend on specific revisions if it's not required, even drop
the whole version if it's fulfillable in stable.
* Standards-Version: 3.6.1 is very outdated, update to current one
* your package builds multiple binary packages, hence you should not
use non-prefixed helpers like debian/dirs and debian/docs, but
explicitly direct them to the right package (e.g. debian/emilda.dirs
here)
* including TODO in *docs isn't very informative, same with README.
* remove the commented useless stuff from the maintainer scripts
* do not use bashisms in the maintainer scripts.
* remove the useless empty lines at the end of the maintainer scripts
* remove the useless empty lines at the end of logrotate
* if you use .install files, you don't need to create the dirs for
them
* remove the useless comented stuff in the watch and rule file
* your build commands are bad, make will not stop processing if
an error occures.
* dh_installexamples and dh_installman is useless
* remove the configure: rule, it's useless
* it has been best-practise to have the dpatches starting with a
number in order of patching.
e.g. fhs_debian.dpatch would be renamed to 01-fhs-debian.dpatch etc.
* fix the shebang of all dpatches (look at the dpatch templates).
* remove the
## All lines beginning with `## DP:' are a description of the patch.
lines from the dpatches, they are useless
* additionally, you want to remove the magic at the beginning,
this is also not needed.
* fix the author information in the dpatches:
it should not be 'by <deckrider@yahoo.com>', but
'by $Prename $Surname <$email>'.
i've not covered all things, but the most important ones. once you fixed
those, i'll look again at the package and tell you the remaining ones.
--
Address: Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email: daniel.baumann@panthera-systems.net
Internet: http://people.panthera-systems.net/~daniel-baumann/
Reply to: