Bug#373966: ITP: qonk -- Small build-and-conquer strategy game with very simple rules

[Goswin von Brederlow <brederlo@informatik.uni-tuebingen.de>]

""=?UTF-8?Q?Mart=C3=ADn_Ferrari?="" <martin.ferrari@gmail.com> writes:

> Hi!
>
> Thanks for your comments!
>
>> The Makefile needs some fixing:
>>
>> - use $(shell ...) instead of ``.
>> - -W -Wall -g in CFLAGS
>
> Also I think I have to make it possible to disable -O. -g shouldn't be
> only for debugging?

You should (must?) always build with -g and the stip the result after
installing them in debian/qonk. This allows users to build the package
locally and run gdb ./qonk or to send you a core file that you can use
with your local unstriped qonk.

You can also support the no opt option to switch -O2 on and
off. Sometimes you need that for debugging. Not very often though.

>> And one maybe serious warning:
>>
>> planets.cpp:331: warning: no return statement in function returning non-void
>
> I will fix it.
>
>> And maybe it should go to the next level on its own without having to
>> restart. :)
>
> Yeah, upstream acknowledges that :) There is a shell script mentioned
> in the website that supposedly does the job, I will check if it's
> suitable.

It should just have a loop inside main() that restarts in the next
level. Shouldn't be that hard. With a shell script the screen would
flicker between levels, not nice.

>> Apart from this it looks like a nice game. Runs on amd64.
>
> Cool! Thanks again!
>
> -- 
> Martín Ferrari

MfG
        Goswin