[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#346564: Uploaded



On Mon, Jan 16, 2006 at 12:06:54PM +0100,
 Andreas Rottmann <a.rottmann@gmx.at> wrote 
 a message of 14 lines which said:

> JFYI: I just uploaded a darcsweb 0.14-1 to sid.

I tested it on a sarge machine and it works fine except if the commit
messages contain Latin-1 characters (darcs does not handle this
properly - issue #33, producing not-wellformed XML, crashing
darcsweb).

The following patch have been sent upstream.

New patches:

[Add the XML decleration that darcs does not add
stephane@sources.org**20051201210549] {
hunk ./darcsweb.cgi 20
+import tempfile
hunk ./darcsweb.cgi 700
-	xmlf = run_darcs("changes --xml-output " + params)
+	raw_xml = run_darcs("changes --xml-output " + params)
+	xmlf = tempfile.TemporaryFile()
+	# Add the XML declaration. darcs should do it but does not. See issue 33
+	# on bugs.darcs.net.
+	xmlf.write('<?xml version="1.0" encoding="%s"?>\n' % config.repoencoding)
+	xmlf.write(raw_xml.read())
+	raw_xml.close()
+	xmlf.seek(0)
hunk ./darcsweb.cgi 709
-	xmlf.close()
-
}

Context:

[fixu8: honour config.repoencoding when decoding characters like [_\e3]
Kirill Smelkov <kirr@mns.spb.ru>**20051130113626] 
[another basic validation issue
Alexandre Rossi <niol@sousmonlit.dyndns.org>**20051112235916
 The issue was that there was an empty line before the XML declaration, which
 is not valid.
] 
[Make how_old() return a fixed date when caching is enabled.
Alberto Bertogli <albertogli@telpin.com.ar>**20051117144133
 
 how_old() becomes a problem when we have a cache, because the relative dates
 will get stalled in the cache.
 
 This is makes a workaround by making how_old() return a string containing the
 fixed date, which isn't quite nice but it will do the trick until a better
 solution comes up.
] 
[Don't close the file in a cache miss.
Alberto Bertogli <albertogli@telpin.com.ar>**20051117144027] 
[Call cache.cancel() only if we have a cache.
Alberto Bertogli <albertogli@telpin.com.ar>**20051117032757] 
[Implement a simple cache.
Alberto Bertogli <albertogli@telpin.com.ar>**20051117031028
 
 This patch implements a very simple but effective cache, so darcsweb can avoid
 regenerating everything all the time.
 
 Based on an idea from Alexandre Rossi.
] 
[Use a more human-friendly format por list configuration variables.
Leandro Lucarella <luca@llucax.hn.org>**20051110152239] 
[Highlight tags in the shortlog/summary.
Alberto Bertogli <albertogli@telpin.com.ar>**20051110003434] 
[Add exclusion lists to multidir configuration.
Alberto Bertogli <albertogli@telpin.com.ar>**20051109235947] 
[TAG 0.12
Alberto Bertogli <albertogli@telpin.com.ar>**20051109011031] 
Patch bundle hash:
e456be38e6e3275be6231bd86bbe663cd6d3d021

Reply to: