Bug#344175: Your RFP for screenie
On Thu, 22 Dec 2005 19:45:45 +0100
Daniel Baumann <daniel.baumann@panthera-systems.net> wrote:
> Marc O. Gloor wrote:
> > Let me know in a qualified manner
> > if the missing escape sequence is the only thing which makes you unhappy.
> Although it was 'qualified' before, I repeat the errors which needs to
> be fixed:
> manpage:
> * Typo: s/Marc/March/
> * Dash escaping: s/-/\/-/g
> script:
> * put 'set -e' and 'set -u' at the beginning of the script
> * remove all unneeded '&&'
> * use "" for variable assignements, e.g. foo="bar"
> * use "" and curly-brackets for variable use, e.g. "${foo}"
> * Remove bashism: use backticks as subshell, e.g. `foo`
> * use rm -f instead of rm, can cause an error depending upon user
> aliases, and remove the useless /dev/null redirection
> * test the script with dash-shell for posix-compliance.
> Unless these things are not fixed, I will not prepare a package.
> However, I suggest you to consider fullfilling the following things too,
> the scripts seems not very worthwile to upload without at least these
> enhancements:
>
> * provide -h|--help parameter
> * provide -u|--usage parameter
> * you may want to move 'written by'-phrase from the 'screenie main
> screen' into a -v|--version parameter output
> * try to use a better coding-style, with special regard to common used
> way of indenting.
> Maybe some more things come up to mind later..
>
> Internet: http://people.panthera-systems.net/~daniel-baumann/
Hi Panthera-Systems board of directors (NYSE listed?)
Probably I would accept Debian specific changes, but I'll never discuss with
a packager about the content of my software. If you suggest non Debian specific
changes that way, send me some patches as contributor. I cancel my RFP.
bye
mg
--
Marc O. Gloor <mgloor at fhzh dot ch>
pgp public key: 0x2CDBF3A1
http://pubwww.fhzh.ch/~mgloor
Reply to: