[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#236418: ITP: debootstrap-buildd -- Scripts to create chroots for building packages



On Sat, Mar 06, 2004 at 03:52:35AM -0800, Daniel Schepler wrote:
> +    if [ "$VARIANT" = ".base" ]; then
> +	VARIANT=""
> +    fi

Err, eww. I really dislike that.

Rest seems fine at first glance. Please talk to Ryan about it, test it a
bit, and then it should be time to do an NMU. You might like to retitle
and reassign the bug to debootstrap, too.

> +SCRIPT="$DEBOOTSTRAP_DIR/scripts/$1$VARIANT"

I'd've done

	if [ "$VARIANT" != "" ]; then
		SCRIPT="${SCRIPT}.${VARIANT}"
	fi

personally. *shrug*

> +.IP "\fB--variant=buildd\fP"
> +Name of the bootstrap script variant to use.  Currently, the only variants
> +supported are base (the default), and buildd, which installs the
> +build-essential packages into

A "variant" isn't the default by def'n, I'd've thought.

Cheers,
aj

-- 
Anthony Towns <aj@humbug.org.au> <http://azure.humbug.org.au/~aj/>
I don't speak for anyone save myself. GPG signed mail preferred.

             Linux.conf.au 2004 -- Because we could.
           http://conf.linux.org.au/ -- Jan 12-17, 2004

Attachment: signature.asc
Description: Digital signature


Reply to: