[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#251715: RFS: libswt3.0-gtk2



Hallo!

This is a repost from a private mail *To* the autor of this package.
As I haven't heard any news on this issues and I have some packages of
my own, which need swt3.0 I resend them to the BTS. 

The current idea of mine is package swt-gtk-3.0 from the eclispe
source and then drop these packages as other package provide the
functionaliy to integrate with the eclipse packages. See this
Bugreport for updates on how far I'm with packageing eclipse3.0:
#260510

In gmane.linux.debian.devel.mentors, you wrote:
>> As this is a java package, you need to follow the debian java policy:
>> libswt3.0-gtk2-java and *-jni for the jni libs.
> I have changed that, the new packages can be found at
> http://mentors.debian.net/debian/pool/main/l/libswt3.0-gtk2-java/

Nice work! I had a look at that and here are my comments:

* gcj compiled files do not go to /usr/lib/jni. /usr/lib/jni is for
jni libs only! As they are ordinary libs, they should go to /usr/lib.
See next item, though...

* I'm pretty sure that the libswt.so needs a readme, adding that it
needs to set LD_LIBRARY_PATH= to /usr/lib/jni to get the jni part of
teh library. Without it, the dlopen call will not find it. Maybe that
is solved with specifiying -rpath in the gcj call, when linking.

* If you put them into /usr/lib, you need to specify shlibs file, so
that othere packages can link against it and get the right dependcies.
See next item, for additional thoughts...

* To work nicely with a motif (or other version of libswt, I would
suggest to add a virtual package, which other packages should depend
on. That would be once libswt3.0-gcj and libswt3.0-java. Then you need
to add the coresponding update-alternatives, so that they are
interchangeable.

For the gcj compiled one, you also need to specify the shlibs file for
the alternative, not the real file.

For the jave one, please follow my idea in my libswt2.1 packages with
a file, which specifies the incldued jars, so that motif (one jar) and
gtk (two jars) are also interchangeable. You need to add a u-a for
that description file then.

* [my taste and because gcj is also incldued] The source package name
should not include the '-java' part.

* xlibs-dev is split up in recent unstable. See the resulting Depends
line of the jni package, how to split up the Build-Depends as well.

* Please add the 'WS' switch in that file, so I can use it in my
eclipse packages.

* The long description of the packages is not there.

* The copyright file is not correct: It misses the Lizenses of the PI
and mozilla jar, and the CPL must be complete.

* The jni package includes SO files, which dependecies do not belong
to the 'Depends:' line. See the attached rules file how to work
around in CDBS. Bad hack, but I figured the that this is the only way
without disabling debhelber. I'm no makefile expert, though...

* Instead of the dh_link call in rules, you can add a
libswt3.0-gtk2-java.links file in debian/, which will be picked up by
the debhelper.mk. Same goes for the Install things. No need to do
something in install/* at all.

* IMO (and not really in line with the *current* java policy, there is
a new one in the making sice a year...), you don't need to add a
symlink to the <name>-<version>.jar file, the <name>.jar is enough.
The version included in the name should be changed, when breaking API
changes are in the jar (which hasn't happend yet at eclipse.org and
swt).

* Along with your ITP, you can close 
#212816: libswt2.1-gtk2-java: Please split off into separate source
         and move to main

I've included the debian dir, which I made during my attempt to
package swt3gtk. Maybe you can find some ideas in there and everything
about the points I've mentioned above. Be aware, that this is really
old work, so there is no additional -jni package (and no gcj) yet. 

The 'update' dir is for updates from the cvs server, but that failed
completly :( I can't get the system to make proper build.xml files for
eclipse itself, when swt is missing or there is a completely installed
eclipse :(

>> Are you also willing to maintain the motif bindings?
> Maybe -- I will take a look at that.

As there is no real differnece between this two packages, I would
really like that. Otherwise I need to package them and I would really
like to keep this two packages together.

For other nice sources, see the gentoo ebuild for 3.0, available from
http://www.gentoo.org/cgi-bin/viewcvs.cgi/*checkout*/dev-util/eclipse-sdk/

I'm not yet a DD (just passed the last step before DAM approval), but
I would like to work closely together with you, so that the eclipse
packages work nicely with your swt packages.

Nice greetings from Karlsruhe, Jan

Attachment: debian.dir.tar.gz
Description: application/tar-gz


Reply to: