[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#236696: comments about the amarok debian packages



Peter,

  I am very glad there are finally some Debian-quality amarok packages
  (yours). I hope they make into unstable soon, but for the moment I
  have some comments about them. I've decided to send these to you now,
  instead of waiting to the RFS in debian-mentors or whatever. I'm
  CC'ing the ITP bug nonetheless; the comments are wrt to version
  1.0.0-2 in <http://www.kalyxo.org/debian/>.

  Comments, in random order more or less; they vary from very important
  to minor improvements:

    - I'd really really recommend placing gstreamer0.8-mad and
      gstreamer0.8-vorbis as dependencies of the gstreamer package,
      instead of just recommends. If not, I guess many users are going
      to be bitten with it. They are really small packages.

    - amarok-gstreamer *must* depend on gstreamer0.8-misc. I'm really
      not happy about it, since it's a big package, but amarok makes use
      of some plugins provided by it. at least: volume, audioscale,
      audioconvert. it won't work otherwise.

    - IMO the section of the packages should be 'kde' instead of
      'sound'. I know, amarok can be used without kde, but 'kde' and
      'gnome' sections were created just to not clutter the other ones,
      and to group apps by desktop environment.

    - /usr/share/doc/amarok-{arts,gstreamer} could (and should) be
      symlinks to /usr/share/doc/amarok.

    - amarokapp is currently statically linked with sqlite. that was a
      decision upstream made, but unless there are strong reasons not to
      do so (and I am not aware of any), debian's executable should be
      dynamically linked and amarok would depend on libsqlite0 then.

    - I strongly suggest not creating a separate package for the arts
      engine. It gives a lot of headache and very little benefit.
      Moreover, I'm quite sure ftpmaster won't allow such a package to
      enter the archive.

  Well, I think that's all for the moment, I wait for your response now.
  If you prefer to talk about it, you can reach me at my_dato@jabber.org
  or perhaps as dato in #amarok.

  cheers,

-- 
Adeodato Simó
    EM: asp16 [ykwim] alu.ua.es | PK: DA6AE621
    Listening to: Diego «El Cigala» & Bebo Valdés - Veinte años
 
One of my most productive days was throwing away 1000 lines of code.
                -- Ken Thompson



Reply to: