[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1079184: marked as done (wine: Removes and generates debian/control at build time)

Your message dated Thu, 29 May 2025 21:00:24 +0000
with message-id <E1uKkMS-006sg3-QX@fasolo.debian.org>
and subject line Bug#1079184: fixed in wine 10.0~repack-4
has caused the Debian Bug report #1079184,
regarding wine: Removes and generates debian/control at build time
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1079184: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1079184
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: wine
Source-Version: 9.0~repack-4
Severity: important

Hi!

This package regenerates the debian/control file on each build, from my
reading of the archive https://ftp-master.debian.org/REJECT-FAQ.html,
this is not allowed.

I realize the regeneration is supposed to not change the content of
the file unless the packaging is for stable or development source
packages. But the above would still seem to apply.

In, practical terms this is causing the following error:

  ,---
  /usr/bin/make -f debian/rules debian/control
  make[2]: Entering directory '/tmp/bd/wine-9.0~repack'
  dpkg-buildapi: error: cannot read debian/control: No such file or directory
  /bin/sh: 1: test: Illegal number: 
  sed "s/VERSION//g;s/DEBSUFFIX/-stable/g" < debian/control.in > debian/control
  `---

Because the debian/control file gets removed before it gets
regenerated. Besides the regeneration issue, I think the control file
should not be removed.

I think, that the current handling might have multiple intents. One
perhaps to generate the debian/control file from debian/control.in if
the former is missing, this can be accomplished as of now with a make
target. Then there is the generation of the file depending on the
source, but that should not change often, or when it changes would be
due to changes in control.in, which would trigger the usual target as
well, but a new target could be created as well to forcibly touch the
source and then depend on the usual target. And finally, perhaps as a
check to make sure that the file always contains the expected result.
For this latter case I guess adding a new target that generates the
file as a temporary, and compares against the canonical
debian/control, and then fails if there's any difference, would
accomplish the check, while not generating it.

Thanks,
Guillem

--- End Message ---
--- Begin Message --- 
Source: wine
Source-Version: 10.0~repack-4
Done: Stephen Kitt <skitt@debian.org>

We believe that the bug you reported is fixed in the latest version of
wine, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1079184@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stephen Kitt <skitt@debian.org> (supplier of updated wine package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 28 May 2025 08:46:37 +0200
Source: wine
Architecture: source
Version: 10.0~repack-4
Distribution: unstable
Urgency: medium
Maintainer: Debian Wine Party <debian-wine@lists.debian.org>
Changed-By: Stephen Kitt <skitt@debian.org>
Closes: 1079184
Changes:
 wine (10.0~repack-4) unstable; urgency=medium
 .
   * Stop rebuilding debian/control, it won't change for the wine package.
     The rebuild recipe is preserved so that future changes to
     debian/control.in can be applied without too much effort, but no
     rebuild should rebuild debian/control (including binNMUs).
     Closes: #1079184.
Checksums-Sha1:
 8276f3a98ba6516ba4d4d3548559115ca0b4fcb9 3860 wine_10.0~repack-4.dsc
 dfc4446fc012673524b7492583d98e306574e9a7 6196528 wine_10.0~repack-4.debian.tar.xz
 e84708662d3523c02e685ceb3963f6d786216b6d 18462 wine_10.0~repack-4_source.buildinfo
Checksums-Sha256:
 3f031605c641a1ec521906531c1592ebea65271a0e028e6ff38dd03404534c45 3860 wine_10.0~repack-4.dsc
 48bb69f71e9bb3805690f1d6e3a6ada1b0230c82f1899aa86f06f6a360edc600 6196528 wine_10.0~repack-4.debian.tar.xz
 819f89f065d2bcea3333e0e61d83a5878391cfe7c81b269d93c4c8ff177d6bea 18462 wine_10.0~repack-4_source.buildinfo
Files:
 15dd80dd508d66ea86dd09de29731030 3860 otherosfs optional wine_10.0~repack-4.dsc
 fab22f606383f184773a3ee2e22885f5 6196528 otherosfs optional wine_10.0~repack-4.debian.tar.xz
 7c2c703df71b9e19b958fe70d2ee8bc5 18462 otherosfs optional wine_10.0~repack-4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmg4BXYRHHNraXR0QGRl
Ymlhbi5vcmcACgkQgNMC9Yhtg5wTEg/+Oyi5lKrxgW0iIfd6q8CPV5aTfOobD04U
ofw4+aJGTPb6AlB+aTyIbSv/BVnNUWcwQTrPLpg549HWPhxLdmcw/8C6MbNtEDqO
Fsb90ckAXo5bO4Ou/qGH3Vx2BIkRBn3Zd7uYiL+3V8CC/uov+/yL4e/FmS0HrRT4
y20qj+kGOv4bG3ThFdx9f+GOKwFdKOHGto45TLxlZz8Ux/uZfF9ycEhrX9LJ6aWi
opJS8sEgLKZ3wEpl6/ORyOMniux/QUuEd7gqcp9PF8YP5sTosV6ImcO/vo3Qpa8w
IHv/+X0OHL9an177klcvvo/ueAq4HBh5w8gTalA8tokIu7sS5/cnuwTaSS+l1z2y
3reEq0Cz08f0kwkezmdxuAaArE2a6OIHik+UHI0aX4FvTPjjt2WR1Uz4LFNiGRDm
zy95xbRzhHZ9NYPzeBsQQBtm/r/cHdW3+BjTTlAWbMwm4Foj/b+jVEuOA2NbM8V6
NPKdaILI1yab7dUBgOTqVsOTEFtLb0N4RJdBpRdgdxdngfTSHtbRIUmCrQBNdhrl
Gjicl7cKrv99WIDBk0cxmFYI75/KzraIZn/3Ep7jZhVyutoHd+i99r8A7sIYvC8P
mmYT6ELk568WoaWvopN4/NeuilSY6DGj8XYrHoBOYZh3vZ5rSPq14MmSXK79OCpZ
SPJwmHRqmHQ=
=OGHD
-----END PGP SIGNATURE-----

Attachment: pgp0_jnqZ_n9_.pgp
Description: PGP signature


--- End Message ---
Reply to: