Bug#1033733: vkd3d: new upstream release 1.12
Control: retitle -1 vkd3d: new upstream release 1.12
On Fri, 31 May 2024 at 12:14:41 +0200, Giovanni Mascellani wrote:
> Il 28/05/24 19:36, Simon McVittie ha scritto:
> > Since then there have been several more upstream releases and it is
> > currently at v1.11.
>
> And now v1.12, just yesterday.
Updated branch at:
https://salsa.debian.org/smcv-guest/vkd3d wip/1.12
Again, I used `uscan --download` to get the orig.tar.* I used for
test-builds.
If the Wine team don't have time to review that packaging update right
now, it could be useful if a team member could prepare an "official"
repacked orig.tar.* for 1.12 and make it available somehow (perhaps
pristine-tar or pristine-lfs) so that forks of this packaging outside
Debian can agree on a shared "single source of truth" orig tarball,
rather than having the orig tarballs inside and outside Debian diverge.
It's looking likely that I will need to upload this to the Steam Runtime
(a specialized Debian derivative) at some point, and if possible
I'd prefer not to have to re-import the upstream source versioned as
1.12~steamrt or similar to avoid that divergence.
Or, if this version isn't felt to be ready for unstable, an upload to
experimental would be a good way to find out whether there are test
regressions on the autobuilders, particularly for non-x86.
> > debian/patches/fixes/byte-comparison.patch no longer applies; I dropped
> > it for now (and the package builds successfully in my environment), but
> > if it's still necessary for other build environments, it will need some
> > adjustment. It would be ideal if this issue could be reported upstream
> > and fixed there.
>
> compare_uint() and compare_color() are now in tests/utils.h. I don't really
> understand in which cases that patch is supposed to help
Right, that's why I didn't update the patch or forward a bug report
upstream - sorry, but it wasn't clear to me what the steps to reproduce
for the bug would be. It was added in 1.2-7, for which the changelog says
"Skip failing tests when using llvmpipe from mesa 21" (but that seems to
be debian/patches/fixes/llvmpipe.patch) and "Skip failing tests when using
nvidia devices" (but that seems to be debian/patches/fixes/nvidia.patch
which was subsequently removed).
In the update to 1.12 I also dropped d/p/fixes/llvmpipe.patch, which
doesn't seem to be necessary with current llvmpipe as of Debian 12
(either that, or I'm not testing it in the same scenario where the skipped
tests would have failed - it's hard to tell which).
I believe having the tests pass with llvmpipe would be sufficient for
the official Debian autobuilders, which don't have access to a real
GPU device node in /dev even if the underlying machine has one.
smcv
Reply to: