[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1012353: Please add support for systemd-binfmt



Package: wine-binfmt
Version: 6.0.3~repack-1
Severity: wishlist
User: pkg-systemd-maintainers@lists.alioth.debian.org
Usertags: systemd-binfmt

Hi,

your package wine-binfmt declares a dependency on binfmt-support and
ships binfmt-support configuration files in /usr/share/binfmt/.

systemd provides a builtin, cross-distro facility named systemd-binfmt to
register binary formats.

You can read more about it at
https://www.freedesktop.org/software/systemd/man/systemd-binfmt.html
https://www.freedesktop.org/software/systemd/man/binfmt.d.html
https://www.kernel.org/doc/html/latest/admin-guide/binfmt-misc.html

The systemd package provides a dpkg file trigger so it is sufficient to
simply install configuration files in /usr/lib/binfmt.d/, no
modifications in the maintainer scripts are necessary.

The attached patch adds support for systemd-binfmt and adjusts the
dependency on binfmt-support accordingly, which now becomes optional.

Please consider applying the attached patch so on a system running
systemd, the binfmt-support dependency can be avoided.

Regards,
Michael

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.17.0-3-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_FIRMWARE_WORKAROUND
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages wine-binfmt depends on:
ii  binfmt-support  2.2.2-1
pn  wine            <none>

wine-binfmt recommends no packages.

wine-binfmt suggests no packages.
diff -Nru wine-6.0.3~repack/debian/binfmt/wine.conf wine-6.0.3~repack/debian/binfmt/wine.conf
--- wine-6.0.3~repack/debian/binfmt/wine.conf	1970-01-01 01:00:00.000000000 +0100
+++ wine-6.0.3~repack/debian/binfmt/wine.conf	2022-06-04 20:35:27.000000000 +0200
@@ -0,0 +1 @@
+:wine:M::MZ::/usr/bin/wine:
diff -Nru wine-6.0.3~repack/debian/changelog wine-6.0.3~repack/debian/changelog
--- wine-6.0.3~repack/debian/changelog	2022-03-13 05:27:41.000000000 +0100
+++ wine-6.0.3~repack/debian/changelog	2022-06-04 20:37:01.000000000 +0200
@@ -1,3 +1,9 @@
+wine (6.0.3~repack-1.1) UNRELEASED; urgency=medium
+
+  * Add support for systemd-binfmt
+
+ -- Michael Biebl <biebl@debian.org>  Sat, 04 Jun 2022 20:37:01 +0200
+
 wine (6.0.3~repack-1) unstable; urgency=medium
 
   * New upstream release 6.0.3, released Feb 25, 2022.
diff -Nru wine-6.0.3~repack/debian/control wine-6.0.3~repack/debian/control
--- wine-6.0.3~repack/debian/control	2022-03-13 05:27:41.000000000 +0100
+++ wine-6.0.3~repack/debian/control	2022-06-04 20:37:01.000000000 +0200
@@ -282,7 +282,7 @@
 Depends:
  ${misc:Depends},
  wine,
- binfmt-support,
+ binfmt-support | systemd,
 Description: Register Wine as the interpreter for Windows executables
  Wine is a free MS-Windows API implementation.
  .
diff -Nru wine-6.0.3~repack/debian/control.in wine-6.0.3~repack/debian/control.in
--- wine-6.0.3~repack/debian/control.in	2022-03-13 05:27:41.000000000 +0100
+++ wine-6.0.3~repack/debian/control.in	2022-06-04 20:36:43.000000000 +0200
@@ -282,7 +282,7 @@
 Depends:
  ${misc:Depends},
  wine,
- binfmt-support,
+ binfmt-support | systemd,
 Description: Register Wine as the interpreter for Windows executables
  Wine is a free MS-Windows API implementation.
  .
diff -Nru wine-6.0.3~repack/debian/wine-binfmt.install wine-6.0.3~repack/debian/wine-binfmt.install
--- wine-6.0.3~repack/debian/wine-binfmt.install	2022-03-13 05:27:38.000000000 +0100
+++ wine-6.0.3~repack/debian/wine-binfmt.install	2022-06-04 20:35:11.000000000 +0200
@@ -1 +1,2 @@
 debian/binfmt/wine usr/share/binfmts
+debian/binfmt/wine.conf usr/lib/binfmt.d/

Reply to: