[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#991822: src:wine: dh_auto_clean deletes unrelated files outside of package source



Control: tags -1 patch

Bálint Réczey <balint@balintreczey.hu> ezt írta (időpont: 2021. aug.
2., H, 18:14):
>
> Package: src:wine
> Severity: critical
> Version: 5.0.3-3
>
> Hi,
>
> The following snippet in debian/rules wiped out every package source
> next to wine and the wine source dir itself, too, because my $HOME is
> stored in git:
>
> ...
> override_dh_auto_clean:
>         git clean -Xdf || true
> ...
>
> It is not safe to assume that the package source is always a git directory.

I suggest using the attached fix.

Cheers,
Balint
From 6f8850be5fe0023040183e4f776f8cc2cb6c8ecd Mon Sep 17 00:00:00 2001
From: Balint Reczey <balint@balintreczey.hu>
Date: Sun, 29 Aug 2021 13:08:13 +0200
Subject: [PATCH] debian/rules: Don't run git clean in dh_auto_clean

Let "make clean" clean up built files instead.

Closes: #991822
---
 debian/rules | 2 --
 1 file changed, 2 deletions(-)

diff --git a/debian/rules b/debian/rules
index d6cf8cd6e98..33048be6fe0 100755
--- a/debian/rules
+++ b/debian/rules
@@ -255,7 +255,6 @@ override_dh_clean:
 	make -f debian/rules debian/control
 
 override_dh_auto_clean:
-	git clean -Xdf || true
 	make -f debian/rules debian/control
 ifeq (,$(filter $(DEB_HOST_ARCH),i386 amd64))
 	# remove zlib patch on non x86 architectures
@@ -263,5 +262,4 @@ ifeq (,$(filter $(DEB_HOST_ARCH),i386 amd64))
 	QUILT_PATCHES=debian/patches quilt delete system/zlib.patch || true
 endif
 	QUILT_PATCHES=debian/patches quilt push -af || true
-	rm -f Makefile
 	dh_auto_clean
-- 
2.30.2


Reply to: