Bug#927139: [src:wine-development] wineserver doens't work when /run/user/pid is not available

[Jens Reyer <jre.winesim@gmail.com>]

cotrol: tags -1 + moreinfo


Hi Konstantin,

On 15.04.19 15:11, Konstantin Demin wrote:
> Source: wine-development
> Version: 4.2-2
> 
> wineserver fails to setup it's directory when /run/user/${pid} is not
> available due to buggy patch.
> please fix debian/patches/fixes/temporary-directory.patch:
> 
> line 65:
> -+            tmp_dir = xmalloc( sizeof(tmp_env) );
> ++            tmp_dir = xmalloc( strlen(tmp_env) + 1 );
> 
> line 110:
> -+            n = fputs( root + sizeof(tmp_dir) + 1, stream );
> ++            n = fputs( root + strlen(tmp_dir) + 1, stream );
> 
> bug is caused by copy-paste mistake, because tmp_env and tmp_dir are
> type of "char *", not "char []", therefore sizeof() isn't equal to
> strlen() + 1.

Thanks for your report.  I can' reproduce the issue here, but
/run/user/$uid exists here (btw: typo pid/uid in your mail).  So can you
please explain more specifically how to trigger this bug?  I'd like to
know if this needs to be fixed for buster.

Besides that, I rebuilt Wine with your fixes and all seems fine.  Your
explanations sound good, but I have to admit I can't really verify them
due to lack of C skills, and in-depth Wine code knowledge.

Greets
jre