[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#898810: marked as done (wine: revert_opengl46.patch applied to wine why no upstream bug.)

Your message dated Sun, 27 May 2018 17:16:00 +0200
with message-id <331631b8-71f8-4b14-7d85-2e3538d6707b@gmail.com>
and subject line Re: Bug#898810: wine: revert_opengl46.patch applied to wine why no upstream bug.
has caused the Debian Bug report #898810,
regarding wine: revert_opengl46.patch applied to wine why no upstream bug.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
898810: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898810
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: wine
Version: 3.0-1
Severity: normal

Dear Maintainer,

I was looking over patches that are being added to wine.

I stumbled on the
https://sources.debian.org/patches/wine/3.0-1/revert_opengl46.patch/ and when I
look at it is in the fact of not right.

Is this caused because you are not using the current khronos files
https://raw.github.com/KhronosGroup/OpenGL-Registry/master/xml/gl.xml
https://raw.github.com/KhronosGroup/OpenGL-Registry/master/xml/wgl.xml

If so work out how to use current kronous files.  Maybe make this
/usr/share/khronos-api directory versioned.   Why is wine project downloading
the kronous files directly is so when users update their opengl to newer
versions old builds of wine stand a chance of working and taking advantage of
newer features.

There is a possiblity that the opengl46 patch is wrong to start off with.
{"GL_EXT_texture_filter_anisotropic",   ARB_TEXTURE_FILTER_ANISOTROPIC}
This line in the patch makes me smell a possible issue that someone might have
done a straight find and replace incorrectly.   If that is the case
EXT_TEXTURE_FILTER_ANISOTROPIC and  ARB_TEXTURE_FILTER_ANISOTROPIC handling
need to be implemented next to each other.   As in try
ARB_TEXTURE_FILTER_ANISOTROPIC if that don't exist try
EXT_TEXTURE_FILTER_ANISOTROPIC and after that fail.  If this is the case there
need to be a wine bug opened and a patch submitted upstream.

Please note I do serousally think this is a bug in wine source code.  From the
gl.xml file from kronous
extension name="GL_ARB_texture_filter_anisotropic" supported="gl|glcore"
extension name="GL_EXT_texture_filter_anisotropic" supported="gl|gles1|gles2"

Note the supported.   Running on android with glex1 or gles2 not seeing
ARB_TEXTURE_FILTER_ANISOTROPIC and only seeing EXT_TEXTURE_FILTER_ANISOTROPIC
would be normal.   Please remember wine is adding android support so has to
support gles1 and gles2 as you even get new android devices today missing
Opengl ES 3.0

If what I suspect is the case and not caused somehow by what you have done with
the khronos files please open upstream bug report in wine.

Peter Dolding




-- Package-specific info:
/usr/bin/wine points to /usr/bin/wine-development.

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.16.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages wine depends on:
ii  wine32  3.0-1+b1
ii  wine64  3.0-1+b1

wine recommends no packages.

Versions of packages wine suggests:
ii  dosbox       0.74-4.3
pn  playonlinux  <none>
pn  winbind      <none>
pn  wine-binfmt  <none>
pn  winetricks   <none>

Versions of packages wine is related to:
ii  fonts-wine               3.0-1
ii  wine                     3.0-1
ii  wine-development [wine]  3.7-1
ii  wine32                   3.0-1+b1
ii  wine64                   3.0-1+b1

-- debconf-show failed

--- End Message ---
--- Begin Message --- 
Fixed in 3.0.1-2 by this change:

Drop opengl compatibility patch and build-depend on khronos-api >= 4.6.


On 05/16/2018 02:40 AM, oiaohm wrote:
> Package: wine
> Version: 3.0-1
> Severity: normal
> 
> Dear Maintainer,
> 
> I was looking over patches that are being added to wine.
> 
> I stumbled on the
> https://sources.debian.org/patches/wine/3.0-1/revert_opengl46.patch/ and when I
> look at it is in the fact of not right.
> 
> Is this caused because you are not using the current khronos files
> https://raw.github.com/KhronosGroup/OpenGL-Registry/master/xml/gl.xml
> https://raw.github.com/KhronosGroup/OpenGL-Registry/master/xml/wgl.xml
> 
> If so work out how to use current kronous files.  Maybe make this
> /usr/share/khronos-api directory versioned.   Why is wine project downloading
> the kronous files directly is so when users update their opengl to newer
> versions old builds of wine stand a chance of working and taking advantage of
> newer features.
> 
> There is a possiblity that the opengl46 patch is wrong to start off with.
> {"GL_EXT_texture_filter_anisotropic",   ARB_TEXTURE_FILTER_ANISOTROPIC}
> This line in the patch makes me smell a possible issue that someone might have
> done a straight find and replace incorrectly.   If that is the case
> EXT_TEXTURE_FILTER_ANISOTROPIC and  ARB_TEXTURE_FILTER_ANISOTROPIC handling
> need to be implemented next to each other.   As in try
> ARB_TEXTURE_FILTER_ANISOTROPIC if that don't exist try
> EXT_TEXTURE_FILTER_ANISOTROPIC and after that fail.  If this is the case there
> need to be a wine bug opened and a patch submitted upstream.
> 
> Please note I do serousally think this is a bug in wine source code.  From the
> gl.xml file from kronous
> extension name="GL_ARB_texture_filter_anisotropic" supported="gl|glcore"
> extension name="GL_EXT_texture_filter_anisotropic" supported="gl|gles1|gles2"
> 
> Note the supported.   Running on android with glex1 or gles2 not seeing
> ARB_TEXTURE_FILTER_ANISOTROPIC and only seeing EXT_TEXTURE_FILTER_ANISOTROPIC
> would be normal.   Please remember wine is adding android support so has to
> support gles1 and gles2 as you even get new android devices today missing
> Opengl ES 3.0
> 
> If what I suspect is the case and not caused somehow by what you have done with
> the khronos files please open upstream bug report in wine.
> 
> Peter Dolding
> 
> 
> 
> 
> -- Package-specific info:
> /usr/bin/wine points to /usr/bin/wine-development.
> 
> -- System Information:
> Debian Release: buster/sid
>   APT prefers testing
>   APT policy: (500, 'testing')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
> 
> Kernel: Linux 4.16.0-1-amd64 (SMP w/2 CPU cores)
> Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU:en (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> LSM: AppArmor: enabled
> 
> Versions of packages wine depends on:
> ii  wine32  3.0-1+b1
> ii  wine64  3.0-1+b1
> 
> wine recommends no packages.
> 
> Versions of packages wine suggests:
> ii  dosbox       0.74-4.3
> pn  playonlinux  <none>
> pn  winbind      <none>
> pn  wine-binfmt  <none>
> pn  winetricks   <none>
> 
> Versions of packages wine is related to:
> ii  fonts-wine               3.0-1
> ii  wine                     3.0-1
> ii  wine-development [wine]  3.7-1
> ii  wine32                   3.0-1+b1
> ii  wine64                   3.0-1+b1
> 
> -- debconf-show failed
>

--- End Message ---
Reply to: