[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[pkg-wine-party] Wine Patches



Hi Mike and others,

I'm cleaning up our patches, see just pushed commits. If it makes sense
I try to get them applied upstream. Now I got 2 questions:


1.)
disable/shlib-exit-calls.patch
description: use abort instead of exit for shared library failure modes

This was triggered by a lintian for libwine.so.1.0, see
https://lintian.debian.org/tags/shlib-calls-exit.html.

I saw your original attempt to get this upstream.

But I don't understand why you also changed libs/wpp/preproc.c and
libs/port/spawn.c. At least for i386 and amd64 these seem not to be
relevant for libwine.so.1.0.


2.)
glu32.patch
description: avoid unneeded libGL dependency for glu32

Is it just unneeded, or were there any issues with it?
Should I push this upstream? Or maybe drop?



And a few suggestions:

3.)
openal.patch
description: openal32: Export EFX extension functions.
bug-debian: http://bugs.debian.org/793548
origin: http://bugs.winehq.org/show_bug.cgi?id=38972

>From the upstream bug: "openal32 now defaults to use the Windows-native
version, so I suspect this bug is fixed."

But at the same time wine-staging still ships this bug.

I tried to test the problematic game. Unfortunately Steam fails before
getting there.

I'd suggest to drop this patch now, and tell the original submitter
about that.


4.)
font-divbyzero.patch
description: avoid divide-by-zero condition for certain font files and
warn about it
bug: https://bugs.winehq.org/show_bug.cgi?id=38762
bug-debian: https://bugs.debian.org/788809

The problematic font has been fixed, and the situation should have
improved with freetype >= 2.6.2.
I'd suggest to drop this patch now.


5.)
printer-resolution.patch
description: set default printer resolution to 600dpi
bug-debian: https://bugs.debian.org/687168

This is more a workaround, than a fix. I suggest to drop this patch and
tell the submitter.
If there's still an issue I'd like to investigate this and have a
upstream bugreport filed. Eventually we might readd this patch then.


Greets
jre



Reply to: