This one time, at band camp, Jan-Pascal van Best said: > Hi Sean and others, > > I'm using the svn version of webapps-common (rev. 109) for the packaging > of phpesp (Bug#421268). I've found that the apache-vhost option creates > wrong Apache config files: the vhost name should be given in a ServerName > directive, not in the <VirtualHost> tag. The current config file breaks > all Apache vhosts :-( > > See patch > > By the way, thanks for the good work on webapps-common. It makes my life > as a packager a lot easier. Any ideas as to when it will be released into > Debian? > > Cheers > > Jan-Pascal > > > --- templates/apache-virtualhost.conf (revision 109) > +++ templates/apache-virtualhost.conf (working copy) > @@ -1,3 +1,4 @@ > -<VirtualHost _WC_VHOST_> > +<VirtualHost *> > + ServerName _WC_VHOST_ > Include /etc/webapps-common/apps-enabled/_WC_HTTPD_/_WC_VHOST_/*.conf > </VirtualHost> <VirtualHost *> is certainly wrong in my environments. I tend to use <VirtualHost 1.2.3.4:80> type declarations. Can we perhaps make this configurable instead? Sean, if you are busy, I can try to take a look over the weekend. -- ----------------------------------------------------------------- | ,''`. Stephen Gran | | : :' : sgran@debian.org | | `. `' Debian user, admin, and developer | | `- http://www.debian.org | -----------------------------------------------------------------
Attachment:
signature.asc
Description: Digital signature