hi matt, On Tue, Oct 18, 2005 at 12:27:10AM +1300, Matt Brown wrote: > Sure, I've attached a patch to fix a bug in the wc_httpd_invoke > function. The function should operate on the list of running httpds, not > any supported httpd. indeed, thanks. i'll throw it in cvs in a bit. > There is also a bug in wc_httpd_running that prevents it from detecting > that apache2 is running. This is due to apache2 being started with > # pgrep -fx /usr/sbin/apache > 17453 > 17454 > # pgrep -fx /usr/sbin/apache2 > # > > # cat /proc/17453/cmdline > /usr/sbin/apache > # cat /proc/17481/cmdline > /usr/sbin/apache2-kstart-DSSL > > Dropping -f and using commands such as pgrep -x apache, or pgrep -x > apache2 would seem to be the best option here. hmm.. tricky. thanks for catching that. i think i'll fall back to just using -x then, as i guess it doesn't get us a whole lot. in either case a clever/mischevious/accidental user could fake us into thinking it was running, but it's not like that's really a big deal i guess. about your patch: > - httpds=$wc_httpd_supported > + httpds=$wc_httpd_running shouldn't that be > - httpds=$wc_httpd_supported > + httpds=`§wc_httpd_runnin` ? sean --
Attachment:
signature.asc
Description: Digital signature