[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [patch] remove .upload files on re-build of a package



* Cyril Brulebois (kibi@debian.org) [141016 08:08]:
> Andreas Barth <aba@ayous.org> (2014-10-15):
> > diff --git a/lib/Buildd/Mail.pm b/lib/Buildd/Mail.pm
> > index cff1880..9741955 100644
> > --- a/lib/Buildd/Mail.pm
> > +++ b/lib/Buildd/Mail.pm
> > @@ -576,6 +576,7 @@ sub prepare_for_upload ($$) {
> >      my $pkg_noep = $pkg;
> >      $pkg_noep =~ s/_\d*:/_/;
> >      my $changes_name = $pkg_noep . "_" . $changes_filename_arch . ".changes";
> > +    my $upload_name = $pkg_noep . "_" . $changes_filename_arch . ".upload";
> >      
> >      for my $upload_dir (@upload_dirs) {
> >      if (! -d $upload_dir &&!mkdir( $upload_dir, 0750 )) {
> > @@ -597,6 +598,7 @@ sub prepare_for_upload ($$) {
> >             }
> >         }
> >  
> > +       system("rm -f -- $upload_dir/$upload_name");
> 
> perldoc -f unlink

I kept the style of the surrounding code. But I don't mind to go to a
bit less ugly code. Any other opinions?


Andi


Reply to: