[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: arch-all-only-packages & database



* Philipp Kern (pkern@debian.org) [140412 23:59]:
> On 2014-04-12 23:16, Andreas Barth wrote:
>> currently source packages which only have arch-all-packages are not in
>> the wanna-build database. This however might have an interessting
>> effect if a package becomes an arch-all-package.
>>
>> I see three ways handling that:
>>
>> 1. Put all arch-all-only-packages into the database
>> 2. Remove a package when it becomes arch-all-only from the database
>> 3. Keep packages in the database if they're historically there, but
>> don't add fresh arch-all-only-packages there
>>
>>
>> What do you think? (The last one is ugly, the second one might loose
>> old failed log entries)
>
> I'd not blow up the database with entries we don't actually need to look  
> at. So either (2) or (3). As wb only tracks source packages (2) does not  
> sound all that bad…

That'd be
--- a/bin/wanna-build
+++ b/bin/wanna-build
@@ -2396,7 +2396,7 @@ sub parse_all_v3 {
     }

     foreach my $name (keys %$db) {
-        next if $srcs->{$name};
+        next if $srcs->{$name} and not isin($srcs->{$name}->{'status'}, qw <arch-all-only>);
         my $pkg = $db->{$name};
         my $logstr = "merge-v3 $vars->{'time'} ".$name."_$pkg->{'version'} ($vars->{'arch'}, $vars->{'suite'}, previous: $pkg->{'state'}):";
         # package disappeared - delete

(I'll apply it tomorrow with the rest of my changes)


Andi


Reply to: