[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Permit architecture qualifiers, and strip them for edos-debcheck



On Sat, Aug 17, 2013 at 03:42:32PM +0200, Andreas Barth wrote:
> * Colin Watson (cjwatson@debian.org) [130817 14:57]:
> > On Sat, Aug 17, 2013 at 02:49:45PM +0200, Andreas Barth wrote:
> > > Adding more qualifiers like native are ok with me if that would
> > > work on our current buildds, but I want to protect our buildds from
> > > running jobs which won't work anyways.
> > 
> > As far as I know :native works fine; certainly my rebase against wheezy
> > of a set of sbuild patches that permitted it came out empty.
> 
> I think we agree on that.
> 
> My comment just refered to the fact that if (at whatever time)
> we add to wanna-build further options, this should only happen after
> buildds actually (means: including run-time configuration like apt)
> support it.

Agreed.

> Other than that, your patch looks good to me. I will apply it unless
> someone disagrees.

Thanks.

As for test cases, obviously there's nothing in the archive, but you
could try this on top of build-essential (patch borrowed/reduced from
Ubuntu):

diff -Nru build-essential-11.6/debian/control build-essential-11.6ubuntu5/debian/control
--- build-essential-11.6/debian/control	2013-01-08 15:54:31.000000000 +0100
+++ build-essential-11.6ubuntu5/debian/control	2013-01-13 03:16:38.000000000 +0100
@@ -4,7 +4,7 @@
 Maintainer: Matthias Klose <doko@debian.org>
 Uploaders: Scott James Remnant <scott@netsplit.com>
 Standards-Version: 3.9.4
-Build-Depends: debhelper (>= 5.0), python3
+Build-Depends: debhelper (>= 5.0), python3:any
 
 Package: build-essential
 Architecture: any
diff -Nru build-essential-11.6/debian/control.in build-essential-11.6ubuntu5/debian/control.in
--- build-essential-11.6/debian/control.in	2013-01-08 14:33:41.000000000 +0100
+++ build-essential-11.6ubuntu5/debian/control.in	2013-01-13 03:16:38.000000000 +0100
@@ -4,7 +4,7 @@
 Maintainer: Matthias Klose <doko@debian.org>
 Uploaders: Scott James Remnant <scott@netsplit.com>
 Standards-Version: 3.9.4
-Build-Depends: debhelper (>= 5.0), python3
+Build-Depends: debhelper (>= 5.0), python3:any
 
 Package: build-essential
 Architecture: any

-- 
Colin Watson                                       [cjwatson@debian.org]


Reply to: