[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: edos: only check source packages


Am Montag, den 24.05.2010, 18:54 +0200 schrieb Andreas Barth:
> I'm suggesting to change edos so that only the installability of
> source packages is checked anymore:
> diff --git a/bin/wb-edos-builddebcheck b/bin/wb-edos-builddebcheck
> index 400d1e3..f04c6fc 100755
> --- a/bin/wb-edos-builddebcheck
> +++ b/bin/wb-edos-builddebcheck
> @@ -73,9 +73,9 @@ if ( $architecture eq "" ) {
>      }
>  }
>  open(RESULT,"python /usr/share/edos-distcheck/add-sources.py ".
> -     "--prefix \"$sourceprefix\" < $packagefile $sourcesfile $architecture ".
> -     "| edos-debcheck $edosoptions|");
> +     "--prefix \"$sourceprefix\" < /dev/null $sourcesfile $architecture".
> +     "| edos-debcheck '-base FILE' $packagefile $edosoptions|");

I did not check, but edos-debcheck --help:

  -base FILE Additional binary package control file providing packages 
             that are not checked but used for resolving dependencies

seems to indicate that all packages mentioned in the file are assumed to
be installable. This would mean that the edos-debcheck test could flag
sources as ready for build that will fail to build on the buildds. (I
might be wrong though.)


PS: The flag specification is a bit strange here. I’d expect "FILE" to
be a replaceable parameter. I wonder if this flag was ever used, as this
does not look intentional to me...

Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

Attachment: signature.asc
Description: This is a digitally signed message part

Reply to: