Uppercasing filenames

[Jeff Elkins <jeffelkins@earthlink.net>]

I need to convert a bunch of filenames to uppercase. I tried the script below, 
which does...nothing.

#!/bin/sh
for file in $*
 do
 if [ -f $file ]
 then
  ucfile=`echo $file | tr [a-z] [A-Z]`
  if [ $file != $ucfile ]
  then
  mv -i $file $ucfile
  fi     
 fi
 done

Any tips?

TIA

Jeff Elkins