Re: fixes for delgroup

[J.R.Blaakmeer@student.utwente.nl]

On Wed, 14 May 1997, George Bonser wrote:

> I fixed a couple of things in /usr/sbin/delgroup (but did not save the
> file first so I could make a diff). The changes are minor and at the top
> of the file.
> 
> was:
> 
> if [ -f /etc/gtmp];
> 
> changed to:
> 
> if [-f /etc/gtmp]; then

You're right here, the original has a syntax error.
 
> Was:
> 
> $GID='id -g mail'
> 
> changed to
> 
> GID=$(id -d mail)
> 
> (which really makes no sense unless the author wants to pick a "safe"
> GID. but I did not look into it any deeper ... the script appears to run
> now).

This indeed doesn't make any sense. I think it must be

GID=$(id -g $1)

This way $GID becomes the GID of the group youare deleting. It is only
used for checking if there are any references to this GID in /etc/passwd.
This might occur if you are deleting a group and the user with the same
name hasn't been deleted.

Remco


--
TO UNSUBSCRIBE FROM THIS MAILING LIST: e-mail the word "unsubscribe" to
debian-user-request@lists.debian.org . 
Trouble?  e-mail to templin@bucknell.edu .